Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sql test connection work with saved Database instance #694

Merged
merged 1 commit into from Sep 17, 2016
Merged

Make sql test connection work with saved Database instance #694

merged 1 commit into from Sep 17, 2016

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jun 29, 2016

Fix #596

@coveralls
Copy link

coveralls commented Jun 29, 2016 •
edited

Coverage Status

Coverage decreased (-0.1%) to 80.96% when pulling 96a430eda80a14284ed7f83b84582c769c535d48 on xrmx:testaftersave into dbb9356 on airbnb:master.

@coveralls
Copy link

coveralls commented Jun 29, 2016 •
edited

Coverage Status

Coverage increased (+0.1%) to 81.207% when pulling 1e3b179724e6580354e3eb549cf710d1afc5e877 on xrmx:testaftersave into dbb9356 on airbnb:master.

@mistercrunch
Copy link
Member

This is awesome! though would you mind addressing the landscape nits?
https://landscape.io/diff/391703

@xrmx
Copy link
Contributor Author

xrmx commented Jun 30, 2016

Fixed and rebased.

@coveralls
Copy link

coveralls commented Jun 30, 2016 •
edited

Coverage Status

Coverage increased (+0.1%) to 81.219% when pulling 26d5eedb025211d057948bced958d71f368273f9 on xrmx:testaftersave into f407bd4 on airbnb:master.

@coveralls
Copy link

coveralls commented Jul 2, 2016 •
edited

Coverage Status

Coverage increased (+0.1%) to 81.158% when pulling 210ef1a4aac5e123b2ae5857c5bc1c7304a880ab on xrmx:testaftersave into 8135c24 on airbnb:master.

@coveralls
Copy link

coveralls commented Jul 15, 2016 •
edited

Coverage Status

Coverage increased (+0.1%) to 81.305% when pulling da33cead30da7728ab1e3a2c6b02e9871a157cd2 on xrmx:testaftersave into 24e85f5 on airbnb:master.

@coveralls
Copy link

coveralls commented Jul 31, 2016 •
edited

Coverage Status

Coverage increased (+0.2%) to 81.353% when pulling d5ee69cc3d9d7b5cdb443568e0610feaed15a670 on xrmx:testaftersave into ee9141a on airbnb:master.

@coveralls
Copy link

coveralls commented Aug 2, 2016 •
edited

Coverage Status

Coverage increased (+0.2%) to 81.701% when pulling b711d2905ade4969af98e78240a146a393721f98 on xrmx:testaftersave into aaef338 on airbnb:master.

@coveralls
Copy link

coveralls commented Aug 2, 2016 •
edited

Coverage Status

Coverage increased (+0.2%) to 81.701% when pulling 8b554d52edd542e5a70bdf01244a637081cd5c0c on xrmx:testaftersave into aaef338 on airbnb:master.

@xrmx xrmx mentioned this pull request Sep 15, 2016
Closed
dennisobrien added a commit to dennisobrien/caravel that referenced this pull request Sep 15, 2016
@dennisobrien
Incorporate the tests from PR apache#694 which addresses apache#596
c795eb9
@mistercrunch mistercrunch merged commit afa1f09 into apache:master Sep 17, 2016
dennisobrien pushed a commit to dennisobrien/caravel that referenced this pull request Sep 19, 2016
@xrmx @dennisobrien
Make sql test connection work with saved Database instance (apache#694)
98da9a0 
Fix apache#596
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

database test connection does not work after model has been saved
3 participants
@xrmx @coveralls @mistercrunch