fix: db installation #10425
Merged
fix: db installation #10425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I did fix the |
6 tasks
villebro
requested changes
Aug 4, 2020
john-bodley
reviewed
Aug 4, 2020
blcksrx
force-pushed
the
db-installaion
branch
3 times, most recently
from
cd959e6
to
69120bf
Compare
john-bodley
reviewed
Aug 4, 2020
john-bodley
approved these changes
Aug 4, 2020
mistercrunch
approved these changes
Aug 5, 2020
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It's not a really good idea to pass the DB installation to the user without specifying a goo version, Also the best practice is providing the extras on the
extras_requireIn addition this PR, depends on this PR:
#10407
Because there's no way to pass the git link to the extras_require
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION