fix(dashboard): changing the chart title, except not #10527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suddjian
changed the title
suddjian
changed the title
suddjian
changed the title
villebro
reviewed
Aug 6, 2020
villebro
approved these changes
Aug 7, 2020
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
* changing slice names in dashboard should not change chart title * comprehensions > loops
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* changing slice names in dashboard should not change chart title * comprehensions > loops
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It often makes sense to have a different title for a chart in the context of a dashboard than the title used for the chart on its own. This change allows that. Title changes made from the dashboard will not affect the chart entity, and will instead be saved in the dashboard data.
TEST PLAN
Change the chart title in the dashboard, verify that it does not change the chart title. Change the chart title from explore view, verify that it does not change the custom title in the dashboard.
ADDITIONAL INFORMATION