Simplifying the flow to add a table #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying a table reference that can not be found, the system used to still create the object, which would result in confusion and bad error messages down the line. Now it will fail and not create the object. I also removed fields that are not necessary to worry about when initially creating the table.
| flasher( | ||
| table = self.get_sqla_table_object() | ||
| except Exception: | ||
| raise Exception( | ||
| "Table doesn't seem to exist in the specified database, " |
There was a problem hiding this comment.
it would be create to provide the DB and Table names in the exception.
|
LGTM |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying a table reference that can not be found, the system used
to still create the object, which would result in confusion and bad
error messages down the line. Now it will fail and not create the
object.
I also removed fields that are not necessary to worry about when
initially creating the table and change some of the flashed messages