refactor(database): use SupersetResultSet on SqlaTable.get_df() #10707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10707 +/- ##
==========================================
- Coverage 64.76% 60.23% -4.54%
==========================================
Files 789 789
Lines 37091 37077 -14
Branches 3555 3555
==========================================
- Hits 24021 22332 -1689
- Misses 12963 14558 +1595
- Partials 107 187 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
force-pushed
the
villebro/viz-result-set
branch
from
83d46d5
to
383664e
Compare
villebro
commented
Aug 28, 2020
| @@ -25,7 +25,7 @@ | |||
| str, str, Optional[str], Optional[str], Optional[int], Optional[int], bool | |||
| ] | |||
| DbapiDescription = Union[List[DbapiDescriptionRow], Tuple[DbapiDescriptionRow, ...]] | |||
| DbapiResult = List[Union[List[Any], Tuple[Any, ...]]] | |||
| DbapiResult = Sequence[Union[List[Any], Tuple[Any, ...]]] | |||
There was a problem hiding this comment.
for some reason MyPy was giving me errors on this locally (I'm probably running a newer version than CI). As I know some Dbapis are actually returning tuples, I think this makes sense anyway.
villebro
force-pushed
the
villebro/viz-result-set
branch
from
8074f28
to
889ab05
Compare
villebro
commented
Aug 28, 2020
| @@ -119,7 +129,7 @@ describe('Visualization > Table', () => { | |||
| it('Test table with percent metrics and groupby', () => { | |||
| const formData = { | |||
| ...VIZ_DEFAULTS, | |||
| percent_metrics: NUM_METRIC, | |||
| percent_metrics: PERCENT_METRIC, | |||
There was a problem hiding this comment.
For some weird reason this test was flaking out when run with NUM_METRIC (I replicated this test locally, but was not able to make it fail). Switching to PERCENT_METRIC below seems to have solved it.
villebro
added a commit
to preset-io/superset
that referenced
this pull request
Aug 29, 2020
…he#10707) * refactor(database): use SupersetResultSet on SqlaTable.get_df() * lint * change cypress test
6 tasks
villebro
added a commit
to preset-io/superset
that referenced
this pull request
Sep 2, 2020
…he#10707) * refactor(database): use SupersetResultSet on SqlaTable.get_df() * lint * change cypress test
villebro
added a commit
that referenced
this pull request
Sep 5, 2020
* refactor(database): use SupersetResultSet on SqlaTable.get_df() * lint * change cypress test
dpgaspar
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 10, 2020
…he#10707) * refactor(database): use SupersetResultSet on SqlaTable.get_df() * lint * change cypress test
villebro
added a commit
to preset-io/superset
that referenced
this pull request
Sep 11, 2020
…he#10707) * refactor(database): use SupersetResultSet on SqlaTable.get_df() * lint * change cypress test
villebro
added a commit
that referenced
this pull request
Sep 11, 2020
* refactor(database): use SupersetResultSet on SqlaTable.get_df() * lint * change cypress test
villebro
added a commit
that referenced
this pull request
Sep 16, 2020
* refactor(database): use SupersetResultSet on SqlaTable.get_df() * lint * change cypress test
Ofeknielsen
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Oct 5, 2020
…he#10707) * refactor(database): use SupersetResultSet on SqlaTable.get_df() * lint * change cypress test
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
…he#10707) * refactor(database): use SupersetResultSet on SqlaTable.get_df() * lint * change cypress test
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…he#10707) * refactor(database): use SupersetResultSet on SqlaTable.get_df() * lint * change cypress test
mistercrunch
added
🍒 0.37.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently
SqlaTable.get_df()is fetching data usingcursor.fetchall()instead ofBaseEngineSpec.fetch_data(), which contains critical customizations for multiple databases. In addition, instead of constructing theDataFrameusingpd.DataFrame.from_records(), we can leverageSupersetResultSetwhich is already implemented on SQL Lab, and which behind the scenes is usingPyArrowfor storing the datastructure. This is a yet another step in the direction of usingSupersetResultSet, and thereforePyArrow, instead of Pandas DataFrames whenever possible.TEST PLAN
CI
ADDITIONAL INFORMATION
Ping: @robdiciuccio