refactor: convert DatasetList schema filter to use new distinct api #10746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nytai
commented
Sep 1, 2020
| @@ -412,5 +412,9 @@ def distinct(self, column_name: str, **kwargs: Any) -> FlaskResponse: | |||
| # Apply pagination | |||
| result = self.datamodel.apply_pagination(query, page, page_size).all() | |||
| # produce response | |||
| result = [{"text": item[0]} for item in result if item[0] is not None] | |||
| result = [ | |||
| {"text": item[0], "value": item[0]} | |||
There was a problem hiding this comment.
changed this to be compliant with the existing /related api
dpgaspar
reviewed
Sep 2, 2020
nytai
force-pushed
the
tai/update-list-view-filters
branch
from
3455f22
to
33ed74b
Compare
nytai
force-pushed
the
tai/update-list-view-filters
branch
from
33ed74b
to
0fdec1e
Compare
willbarrett
approved these changes
Sep 2, 2020
amitmiran137
pushed a commit
to ofekisr/incubator-superset
that referenced
this pull request
Sep 7, 2020
…boards_permissions * upstream/master: (32 commits) docs: Add a note to contributing.md on reporting security vulnerabilities (apache#10796) Fix: Include RLS filters for cache keys (apache#10805) feat: filters for database list view (apache#10772) fix: MVC show saved query (apache#10781) added creator column and adjusted order columns (apache#10789) security: disallow uuid package on jinja2 (apache#10794) feat: CRUD REST API for saved queries (apache#10777) fix: disable domain sharding on explore view (apache#10787) fix: can not type `0.05` in `TextControl` (apache#10778) fix: pivot table timestamp grouping (apache#10774) fix: add validator information to email/slack alerts (apache#10762) More Label touchups (margins) (apache#10722) fix: dashboard extra filters (apache#10692) fix: re-installing local superset in cache image (apache#10766) feat: SIP-34 table list view for databases (apache#10705) refactor: convert DatasetList schema filter to use new distinct api (apache#10746) chore: removing fsevents dependency (apache#10751) Fix precommit hook for docs/installation.rst (apache#10759) feat(database): POST, PUT, DELETE API endpoints (apache#10741) docs: Update OAuth configuration in installation.rst (apache#10748) ...
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
-CI, unit tests, manual testing.
ADDITIONAL INFORMATION