Single quote filter values with comma #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vera-liu
force-pushed
the
vliu_comma_in_filter
branch
3 times, most recently
from
0cbf180
to
82b828d
Compare
| @@ -53,6 +54,7 @@ | |||
| config = app.config | |||
|
|
|||
| QueryResult = namedtuple('namedtuple', ['df', 'query', 'duration']) | |||
| FillterPattern = re.compile(r'''((?:[^,"']|"[^"]*"|'[^']*')+)''') | |||
|
This tooltip should make it clear that single quotes should be used to encapsulate strings that contain commas. |
vera-liu
force-pushed
the
vliu_comma_in_filter
branch
2 times, most recently
from
3a2b0a3
to
b777552
Compare
|
LGTM |
vera-liu
force-pushed
the
vliu_comma_in_filter
branch
from
b777552
to
4baaa27
Compare
dennisobrien
pushed a commit
to dennisobrien/caravel
that referenced
this pull request
Sep 19, 2016
* Single quote filter values with comma * refactor for codeclimate limite * Added unit tests and tooltip
This was referenced Jun 2, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…pache#1084) * feat(plugin-chart-graph): add node/edge size and edge symbol control * Fix test case
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…pache#1084) * feat(plugin-chart-graph): add node/edge size and edge symbol control * Fix test case
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…pache#1084) * feat(plugin-chart-graph): add node/edge size and edge symbol control * Fix test case
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…pache#1084) * feat(plugin-chart-graph): add node/edge size and edge symbol control * Fix test case
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs-review @ascott @mistercrunch @bkyryliuk
After: