Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues using Filter Box when a comma is in the value #1045

Closed
mistercrunch opened this issue Aug 30, 2016 · 6 comments
Closed

Issues using Filter Box when a comma is in the value #1045

mistercrunch opened this issue Aug 30, 2016 · 6 comments
Assignees
@vera-liu
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@mistercrunch
Copy link
Member

No description provided.

@yzliao
Copy link

yzliao commented Aug 30, 2016

The same error also happens in flt_eq_1: field

@mistercrunch mistercrunch added the !deprecated-label:bug Deprecated label - Use #bug instead label Aug 31, 2016
@vera-liu
Copy link
Contributor

vera-liu commented Sep 8, 2016 •
edited

https://github.com/airbnb/caravel/blob/0e0eaa0ccdef37abf4a072776d7a0da3deab0d62/caravel/models.py#L837

@yzliao
Copy link

yzliao commented Sep 8, 2016 •
edited

@vera-liu Is this a new patch or the existing code?

I think this line of code does not consider that value may also contain a comma. For example, if value='Tahoe, CA', this line will produce two values, Tahoe and CA. However, they should be combined together.

cc: @Patrick1860

@vera-liu
Copy link
Contributor

vera-liu commented Sep 9, 2016

Sorry for the spam before, I proposed a solution by requiring values with comma to be wrapped in single quote. For instance, values of "A, B, 'Tahoe, CA', D" will be treated as ['A', 'B', 'Tahoe, CA', 'D'] after this fix
PR here:
https://github.com/airbnb/caravel/pull/1084

@yzliao
Copy link

yzliao commented Sep 9, 2016

Thank you! This PR LGTM.

@xrmx
Copy link
Contributor

xrmx commented Sep 18, 2016

Closing as fixed in #1084

@xrmx xrmx closed this as completed Sep 18, 2016
@vera-liu vera-liu mentioned this issue Sep 21, 2016
Closed
@dpgaspar dpgaspar mentioned this issue Jul 8, 2019
Merged
3 tasks
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
@ktmud @zhaoyongjie
fix(legacy-plugin-chart-country-map): higher quality geojson and re-a…
9285280 
…rrange controls (apache#1045)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
@ktmud @zhaoyongjie
fix(legacy-plugin-chart-country-map): higher quality geojson and re-a…
d75e0ea 
…rrange controls (apache#1045)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
@ktmud @zhaoyongjie
fix(legacy-plugin-chart-country-map): higher quality geojson and re-a…
11b8ed8 
…rrange controls (apache#1045)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
@ktmud @zhaoyongjie
fix(legacy-plugin-chart-country-map): higher quality geojson and re-a…
cbaec13 
…rrange controls (apache#1045)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vera-liu vera-liu

Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xrmx @mistercrunch @yzliao @vera-liu