Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated type: ignore of helper in models #10906

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

kkucharc
Copy link
Contributor

SUMMARY

Removing #type: ignored by adding type for sql alchemy's mapper.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

	- added sql alchemy mapper as a type
@kkucharc
Copy link
Contributor Author

@willbarrett This is minor changes which I found during other task. Would you find a time to take a look if it makes sense?

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2020

Codecov Report

Merging #10906 into master will decrease coverage by 0.58%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10906      +/-   ##
==========================================
- Coverage   61.35%   60.77%   -0.59%     
==========================================
  Files         380      382       +2     
  Lines       24083    24144      +61     
==========================================
- Hits        14777    14674     -103     
- Misses       9306     9470     +164     
Flag Coverage Δ
#python 60.77% <75.00%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/helpers.py 89.25% <75.00%> (+0.05%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 53.90% <0.00%> (-30.08%) ⬇️
superset/db_engine_specs/presto.py 70.85% <0.00%> (-11.44%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 97.36% <0.00%> (-2.64%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 87.56% <0.00%> (-0.83%) ⬇️
superset/models/dashboard.py 88.03% <0.00%> (-0.28%) ⬇️
superset/connectors/sqla/models.py 89.61% <0.00%> (-0.14%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38edb69...ccaaa2e. Read the comment docs.

@kkucharc kkucharc changed the title Updated type: ignore of helper in models fix: updated type: ignore of helper in models Sep 16, 2020
@willbarrett willbarrett merged commit 141ef4a into apache:master Sep 17, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
- added sql alchemy mapper as a type
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants