chore: Dashboard cypress refactor

[adam-stasiak]

SUMMARY

Cypress selectors instead of class selectors in dashboard.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-commenter]

Codecov Report

Merging #11049 into master will increase coverage by 0.33%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #11049      +/-   ##
==========================================
+ Coverage   61.36%   61.69%   +0.33%     
==========================================
  Files         383      816     +433     
  Lines       24188    38589   +14401     
  Branches        0     3650    +3650     
==========================================
+ Hits        14842    23806    +8964     
- Misses       9346    14603    +5257     
- Partials        0      180     +180     

Flag	Coverage Δ
#javascript	62.18% <75.00%> (?)
#python	61.39% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/components/DeleteModal.tsx	100.00% <ø> (ø)
superset-frontend/src/components/EditableTitle.tsx	74.28% <ø> (ø)
superset-frontend/src/components/FaveStar.tsx	80.95% <ø> (ø)
...rset-frontend/src/components/ListView/ListView.tsx	96.00% <ø> (ø)
...ontend/src/components/ListView/TableCollection.tsx	100.00% <ø> (ø)
...set-frontend/src/components/ListViewCard/index.tsx	93.47% <ø> (ø)
superset-frontend/src/components/Modal.tsx	94.11% <ø> (ø)
...frontend/src/dashboard/components/AddSliceCard.jsx	50.00% <0.00%> (ø)
.../src/dashboard/components/BuilderComponentPane.jsx	33.33% <ø> (ø)
...tend/src/dashboard/components/DashboardBuilder.jsx	77.27% <ø> (ø)
... and 451 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b458ac...796aae0. Read the comment docs.

[rusackas]

Left lots of little comments/concerns questions. The real fix needed here is in reference to some icon names that don't look right. Otherwise, the big theme around the questions/suggestions is about adding more specific/explicit data-test attributes, in more targeted places, so we don't have to rely on traversing elements with find/children/siblings/last/etc, and we don't have problems caused by generic selectors, e.g. if more than one cancel-button is on the screen at once, or if we're in the wrong modal but there's still a cancel-button viible. Kind of a hypothetical problem, but I think you get the intent.