Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove erroneous package-lock.json #11108

Conversation

robdiciuccio
Copy link
Member

SUMMARY

Removes erroneous package-lock.json at top of repo added in recent PR.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@robdiciuccio
Copy link
Member Author

Note that this is mainly a test of a new ticketing system's Github integration on Preset's end, but still a valid cleanup task.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020

Codecov Report

Merging #11108 into master will decrease coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11108      +/-   ##
==========================================
- Coverage   61.54%   60.52%   -1.02%     
==========================================
  Files         817      384     -433     
  Lines       38706    24305   -14401     
  Branches     3650        0    -3650     
==========================================
- Hits        23821    14711    -9110     
+ Misses      14705     9594    -5111     
+ Partials      180        0     -180     
Flag Coverage Δ
#javascript ?
#python 60.52% <ø> (-0.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 53.90% <0.00%> (-30.08%) ⬇️
superset/db_engine_specs/presto.py 70.60% <0.00%> (-11.36%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 97.36% <0.00%> (-2.64%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 87.56% <0.00%> (-0.83%) ⬇️
superset/connectors/sqla/models.py 89.70% <0.00%> (-0.14%) ⬇️
...rset-frontend/src/setup/setupErrorMessagesExtra.ts
superset-frontend/src/explore/exploreUtils.js
... and 434 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6633409...e353446. Read the comment docs.

@willbarrett willbarrett merged commit 6f61982 into apache:master Oct 6, 2020
@willbarrett willbarrett deleted the robdiciuccio/ch97/cleanup-package-lock-json branch October 6, 2020 01:31
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants