Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename ImportMixin to ImportExportMixin #11460

Merged
merged 20 commits into from
Oct 30, 2020

Conversation

betodealmeida
Copy link
Member

SUMMARY

The mixin has been used not just for import, but also for export. Renaming it for consistency.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

Unit tests all pass.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@willbarrett willbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 28, 2020

Codecov Report

Merging #11460 into SO-1095 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           SO-1095   #11460   +/-   ##
========================================
  Coverage    61.91%   61.91%           
========================================
  Files          864      864           
  Lines        41047    41047           
  Branches      3693     3693           
========================================
  Hits         25415    25415           
  Misses       15453    15453           
  Partials       179      179           
Flag Coverage Δ
#javascript 62.87% <ø> (ø)
#python 61.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/base/models.py 89.43% <100.00%> (ø)
superset/connectors/druid/models.py 82.48% <100.00%> (ø)
superset/models/core.py 88.30% <100.00%> (ø)
superset/models/dashboard.py 80.63% <100.00%> (ø)
superset/models/helpers.py 87.91% <100.00%> (ø)
superset/models/schedules.py 86.79% <100.00%> (ø)
superset/models/slice.py 86.80% <100.00%> (ø)
superset/models/sql_lab.py 90.97% <100.00%> (ø)
superset/views/base.py 73.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e455bf...0e3c996. Read the comment docs.

@betodealmeida betodealmeida changed the base branch from SO-1095 to master October 30, 2020 15:36
@betodealmeida betodealmeida merged commit f2b8d6a into apache:master Oct 30, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* Add UUID to saved_query

* Reuse function from previous migration

* Point to new head

* feat: add backend to export saved queries using new format

* Rename ImportMixin to ImportExportMixin
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants