Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add affordances for new export functionality #11559

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

betodealmeida
Copy link
Member

SUMMARY

This was reviewed in #11373 but merged to the wrong branch (not master).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See original PR.

TEST PLAN

Tested all the exports manually.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #11559 into master will decrease coverage by 4.28%.
The diff coverage is 63.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11559      +/-   ##
==========================================
- Coverage   66.59%   62.31%   -4.29%     
==========================================
  Files         876      876              
  Lines       42074    42105      +31     
  Branches     3919     3933      +14     
==========================================
- Hits        28021    26239    -1782     
- Misses      13950    15684    +1734     
- Partials      103      182      +79     
Flag Coverage Δ
cypress ?
javascript 62.58% <63.26%> (-0.02%) ⬇️
python 62.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/utils.tsx 45.88% <0.00%> (-4.12%) ⬇️
superset/config.py 90.15% <ø> (ø)
superset/views/database/views.py 87.43% <ø> (ø)
...tend/src/views/CRUD/data/database/DatabaseList.tsx 79.31% <58.33%> (-2.51%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartCard.tsx 83.87% <66.66%> (-12.29%) ⬇️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 69.23% <66.66%> (-2.74%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 72.72% <75.00%> (-14.53%) ⬇️
superset-frontend/src/featureFlags.ts 89.47% <100.00%> (-10.53%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6981017...0adcb3f. Read the comment docs.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betodealmeida betodealmeida merged commit d999802 into apache:master Nov 4, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants