Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): ordering for add chart widget #11672

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

nytai
Copy link
Member

@nytai nytai commented Nov 12, 2020

SUMMARY

Please see linked issue

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-11-12 at 8 33 52 AM

TEST PLAN

Manually tested:

  • all attributes on card are rendered
  • links on the card work
  • sorting by different attributes

ADDITIONAL INFORMATION

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #11672 (dcb988b) into master (542d2e3) will decrease coverage by 10.28%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #11672       +/-   ##
===========================================
- Coverage   65.50%   55.22%   -10.29%     
===========================================
  Files         874      406      -468     
  Lines       42344    14344    -28000     
  Branches     3972     3691      -281     
===========================================
- Hits        27739     7922    -19817     
+ Misses      14476     6259     -8217     
- Partials      129      163       +34     
Flag Coverage Δ
cypress 55.22% <ø> (+7.27%) ⬆️
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/dashboard/actions/sliceEntities.js 75.75% <ø> (+63.63%) ⬆️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...src/components/FilterableTable/FilterableTable.tsx 2.64% <0.00%> (-83.43%) ⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx 5.71% <0.00%> (-82.10%) ⬇️
...et-frontend/src/components/ListView/ActionsBar.tsx 11.11% <0.00%> (-81.20%) ⬇️
... and 729 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 542d2e3...dcb988b. Read the comment docs.

@nytai nytai changed the title fix(dashboard): proper ordering for add chart widget fix(dashboard): ordering for add chart widget Nov 12, 2020
@nytai nytai merged commit 1dc4c47 into apache:master Nov 12, 2020
@nytai nytai deleted the tai/fix-dashboard-chart-order branch November 12, 2020 21:10
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dashboard][Add chart] Chart list is out of order
4 participants