Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: statds metrics for cache invalidation #11701

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

bkyryliuk
Copy link
Member

SUMMARY

adds statsd metric for cache invalidation
fixes gauge interface for statsd: https://statsd.readthedocs.io/en/stable/types.html

TEST PLAN

unit tests

@bkyryliuk bkyryliuk marked this pull request as draft November 14, 2020 00:41
@codecov-io
Copy link

codecov-io commented Nov 14, 2020

Codecov Report

Merging #11701 (16dc573) into master (95246e8) will decrease coverage by 6.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11701      +/-   ##
==========================================
- Coverage   62.86%   55.96%   -6.90%     
==========================================
  Files         889      408     -481     
  Lines       43054    14469   -28585     
  Branches     4016     3729     -287     
==========================================
- Hits        27064     8097   -18967     
+ Misses      15811     6207    -9604     
+ Partials      179      165      -14     
Flag Coverage Δ
cypress 55.96% <ø> (?)
javascript ?
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.48%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx 5.71% <0.00%> (-82.10%) ⬇️
...et-frontend/src/components/ListView/ActionsBar.tsx 11.11% <0.00%> (-81.20%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 0.00% <0.00%> (-80.00%) ⬇️
superset-frontend/src/components/Link.tsx 7.69% <0.00%> (-79.81%) ⬇️
... and 789 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95246e8...16dc573. Read the comment docs.

@bkyryliuk bkyryliuk marked this pull request as ready for review November 14, 2020 02:22
@willbarrett willbarrett merged commit a16a2b8 into apache:master Nov 16, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* Add more logging to the cache invalidation

* Address linter & tests

* Fix linter

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants