Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unbreak frontend ci #11806

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Nov 25, 2020

SUMMARY

Looks like this snuck in because something wasn't rebased off of other work.

TEST PLAN

CI, the frontend job should pass now

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

to: @graceguo-supercat @kgabryje @betodealmeida

@codecov-io
Copy link

codecov-io commented Nov 25, 2020

Codecov Report

Merging #11806 (afe6228) into master (9b68b65) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11806      +/-   ##
==========================================
- Coverage   63.64%   63.28%   -0.36%     
==========================================
  Files         448      905     +457     
  Lines       27567    43922   +16355     
  Branches        0     4221    +4221     
==========================================
+ Hits        17544    27795   +10251     
- Misses      10023    15948    +5925     
- Partials        0      179     +179     
Flag Coverage Δ
javascript 62.95% <100.00%> (?)
python 63.47% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/components/ListViewCard/index.tsx 94.54% <100.00%> (ø)
superset/db_engine_specs/presto.py 73.65% <0.00%> (-8.64%) ⬇️
superset/examples/world_bank.py 97.10% <0.00%> (-2.90%) ⬇️
superset/examples/birth_names.py 96.51% <0.00%> (-2.33%) ⬇️
superset/models/core.py 88.58% <0.00%> (-0.28%) ⬇️
superset/connectors/sqla/models.py 90.62% <0.00%> (-0.14%) ⬇️
superset-frontend/src/explore/dateFilterUtils.ts 100.00% <0.00%> (ø)
...nd/src/dashboard/util/isInDifferentFilterScopes.js 66.66% <0.00%> (ø)
...perset-frontend/src/addSlice/AddSliceContainer.tsx 75.86% <0.00%> (ø)
...src/explore/components/controls/VizTypeControl.jsx 80.00% <0.00%> (ø)
... and 453 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b68b65...afe6228. Read the comment docs.

@etr2460 etr2460 merged commit e4d0288 into apache:master Nov 25, 2020
@rusackas
Copy link
Member

Thanks for the quick fix! Sorry it slipped through. The big green button cannot be taken at face value, it seems!

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants