fix: Adding and removing annotations

[agatapst]

SUMMARY

This fix covers adding, editing and removing annotation layers.
It closes #11782 where everything was explained with details.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Adding annotation

before:

after:

Removing annotation

before:

after:

TEST PLAN

Please verify manually. Steps to recreate issue are described on the Issue #11782 page.

ADDITIONAL INFORMATION

• Has associated issue: Fixes [annotation]add and remove annotation is not working #11782
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

cc @adam-stasiak

[junlincc]

manually tested from local, LGTM. thanks for including the edge case of handling same annotation layers name

[codecov-io]

Codecov Report

Merging #11811 (0b9501a) into master (84c8a62) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #11811   +/-   ##
=======================================
  Coverage   63.54%   63.55%           
=======================================
  Files         915      915           
  Lines       44358    44355    -3     
  Branches     4221     4221           
=======================================
- Hits        28189    28188    -1     
+ Misses      15990    15988    -2     
  Partials      179      179           

Flag	Coverage Δ
javascript	62.97% <0.00%> (+0.01%)	⬆️
python	63.88% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rc/explore/components/controls/AnnotationLayer.jsx	0.00% <0.00%> (ø)
...ore/components/controls/AnnotationLayerControl.jsx	8.45% <0.00%> (-0.38%)	⬇️
superset/views/base_api.py	97.61% <0.00%> (-0.48%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c8a62...0b9501a. Read the comment docs.

[villebro]

Good work @agatapst , in addition to the fix I like the refactoring done here 👍

[junlincc]

let's merge if everything looks alright, other upcoming PRs around this area will rely on this.

[adam-stasiak]

Tested - It is working fine. One short question related to logic of this feature @junlincc :
Should all added annotation layers be included in summary in manage menu? It is not included now.