chore: Change chart_is_fav to chart_is_favorite

[nikolagigic]

SUMMARY

Change chart_is_fav to chart_is_favorite

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #12075 (0d11b76) into master (ba952ba) will decrease coverage by 2.41%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #12075      +/-   ##
==========================================
- Coverage   66.31%   63.90%   -2.42%     
==========================================
  Files         994      484     -510     
  Lines       49033    29759   -19274     
  Branches     4977        0    -4977     
==========================================
- Hits        32515    19016   -13499     
+ Misses      16373    10743    -5630     
+ Partials      145        0     -145     

Flag	Coverage Δ
cypress	?
javascript	?
python	63.90% <100.00%> (-0.32%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/charts/filters.py	96.42% <100.00%> (ø)
superset/dashboards/filters.py	97.05% <100.00%> (ø)
superset/sql_validators/postgres.py	50.00% <0.00%> (-50.00%)	⬇️
superset/db_engine_specs/mysql.py	79.59% <0.00%> (-12.25%)	⬇️
superset/db_engine_specs/sqlite.py	65.62% <0.00%> (-9.38%)	⬇️
superset/databases/commands/create.py	83.67% <0.00%> (-8.17%)	⬇️
superset/databases/commands/update.py	85.71% <0.00%> (-8.17%)	⬇️
superset/utils/celery.py	96.42% <0.00%> (-3.58%)	⬇️
superset/models/core.py	85.86% <0.00%> (-2.99%)	⬇️
superset/views/core.py	72.89% <0.00%> (-2.48%)	⬇️
... and 515 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba952ba...0d11b76. Read the comment docs.

[nytai]

We should probably update instances of this filter in the frontend too, so we don't break any pages between commits.

[nikolagigic]

We should probably update instances of this filter in the frontend too, so we don't break any pages between commits.

what other instances on the front-end are there?

[rusackas]

LGTM. @nytai I'm not seeing any other instances of this either... are we missing something?

[nytai]

Oh never mind, I thought you were doing dashboard_is_fav as well, so the files changed number looked low

[rusackas]

Converting to draft, awaiting merge of #12060 first.

[rusackas]

@nikolagigic Maybe you want to give the same treatment to dashboard_is_fav on this PR too, whilst we're waiting?

[nikolagigic]

@nikolagigic Maybe you want to give the same treatment to dashboard_is_fav on this PR too, whilst we're waiting?

will do

[rusackas]

LGTM