test: rename column names for birth_names dataset

[ktmud]

SUMMARY

Rename sum_girls to num_girls and sum_boys to num_boys in the example birth_names dataset as they are kind of confusing when used in combination with adhoc metrics.

Must wait for: apache-superset/examples-data#7

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

CI and local visual verification

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[junlincc]

thanks for making the change.
for transparency - mihir and i had some confusion while auditing the table viz control panel by mistaken sum_girls as a aggregated field.

[codecov-io]

Codecov Report

Merging #12082 (34e29a4) into master (fd15dff) will decrease coverage by 3.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #12082      +/-   ##
==========================================
- Coverage   66.36%   62.81%   -3.56%     
==========================================
  Files        1014     1014              
  Lines       49513    49499      -14     
  Branches     5066     5066              
==========================================
- Hits        32861    31094    -1767     
- Misses      16508    18196    +1688     
- Partials      144      209      +65     

Flag	Coverage Δ
cypress	?
javascript	60.69% <ø> (ø)
python	64.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/examples/birth_names.py	98.83% <100.00%> (ø)
superset-frontend/src/SqlLab/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/chart/ChartContainer.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/reducers/index.js	0.00% <0.00%> (-100.00%)	⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx	0.00% <0.00%> (-100.00%)	⬇️
...et-frontend/src/filters/components/Select/types.ts	0.00% <0.00%> (-100.00%)	⬇️
...t-frontend/src/explore/reducers/getInitialState.js	0.00% <0.00%> (-100.00%)	⬇️
...-frontend/src/visualizations/presets/MainPreset.js	0.00% <0.00%> (-100.00%)	⬇️
... and 168 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd15dff...34e29a4. Read the comment docs.

[ktmud]

The dataset was updated in apache-superset/examples-data#7

[junlincc]

LGTM! Thank you ktmud!

fyi: @adam-stasiak you may wanna update test cases accordingly

[robdiciuccio]

Looks like this introduced a regression with example dashboards. @junlincc let's ensure PRs are code reviewed before being approved.

[ktmud]

I wouldn't categorize this as a regression, at most an inconvenience for developers. I personally would nuke examples database all the time whenever a new example dashboard is added.

We were aware of the risk of breaking the example dashboard, but decided to take the risk. In addition to much more work, it would also be a little weird to write a db migration or anything special just for this when most production deployments wouldn't load the examples to begin with.

Maybe better documentation next time.

[junlincc]

@robdiciuccio i don't consider this as a regression neither, it's an improvement. As I added in the comment, those column names are not clear which mislead users to read the chart. And i actually did the code review as well, I understood all the changes in 11 files.

In terms of the risk of breaking dashboard, I specifically asked Adam to update the test case accordingly.

[robdiciuccio]

Definitely seems worthy of a mention in UPDATING.md at the very least, as use cases for example dashboards are clearly different for different organizations.

[junlincc]

sure.
i also suggest organizations to read through PR's description and details to understand the changes and risks, before merging a PR into their fork.