fix: Fix chart save and go button

[michael-s-molina]

Resolves #11748

ANIMATED GIF

@rusackas @junlincc

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[ktmud]

LGTM. Could you confirm whether this added dashboardId will persist in chart formData when you save? (It probably shouldn't. But shouldn't be a problem if it does.)

[ktmud]

Thanks for catching this use case and making Superset more intuitive to use, @junlincc !

[rusackas]

LGTM. Could you confirm whether this added dashboardId will persist in chart formData when you save? (It probably shouldn't. But shouldn't be a problem if it does.)

Thanks @ktmud - this is a good catch. Agree that it's non-blocking, so I hit the big green button, but @michael-s-molina if you could confirm and file another PR to fix if it's persisting that, it would be appreciated! And thank you for this great UX improvement!

[michael-s-molina]

@ktmud @rusackas I checked and it's not persisting.

The getFormDataFromControls(explore.controls) in ExploreViewContainer.jsx returns a form_data without the dashboardId because there is no such property in controls schema.

function mapStateToProps(state) {
  const { explore, charts, impressionId } = state;
  const form_data = getFormDataFromControls(explore.controls);
  ...
}