Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alert/report): remove crontab guru link from add/edit modal #12467

Merged
merged 1 commit into from
Jan 13, 2021
Merged

fix(alert/report): remove crontab guru link from add/edit modal #12467

merged 1 commit into from
Jan 13, 2021

Conversation

lilykuang
Copy link
Member

SUMMARY

  • remove crontab guru link from alert/report add/edit modal

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE
Alert Modal:
Screen Shot 2021-01-12 at 11 21 44 AM
Report Modal:
Screen Shot 2021-01-12 at 11 22 29 AM

AFTER
Alert Modal:
Screen Shot 2021-01-12 at 11 20 35 AM
Report Modal:
Screen Shot 2021-01-12 at 11 19 15 AM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@willbarrett willbarrett deleted the lily/remove-crontab-guru branch January 13, 2021 18:49
@willbarrett willbarrett merged commit 908c0f2 into apache:master Jan 13, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
remove crontab guru link (apache#12467)
50310c8
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarrett willbarrett willbarrett approved these changes

@nytai nytai nytai approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilykuang @willbarrett @nytai @mistercrunch