Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: speedup celery tests #12885

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

kstrz
Copy link
Contributor

@kstrz kstrz commented Feb 2, 2021

SUMMARY

Speedup async celery tests by querying db in 0.5 s intervals instead of waiting 6s.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@kstrz
Copy link
Contributor Author

kstrz commented Feb 2, 2021

Hey! Could you look at it? @willbarrett @dpgaspar

@codecov-io
Copy link

Codecov Report

Merging #12885 (f350b57) into master (2adfb85) will decrease coverage by 1.51%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12885      +/-   ##
==========================================
- Coverage   64.89%   63.38%   -1.52%     
==========================================
  Files        1024      489     -535     
  Lines       50168    30197   -19971     
  Branches     5148        0    -5148     
==========================================
- Hits        32557    19139   -13418     
+ Misses      17433    11058    -6375     
+ Partials      178        0     -178     
Flag Coverage Δ
cypress ?
javascript ?
python 63.38% <ø> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/database/views.py 62.50% <0.00%> (-25.07%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/sql_validators/base.py 93.33% <0.00%> (-6.67%) ⬇️
superset/db_engine_specs/base.py 79.59% <0.00%> (-6.38%) ⬇️
superset/db_engine_specs/presto.py 82.25% <0.00%> (-6.28%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/views/database/forms.py 83.33% <0.00%> (-5.56%) ⬇️
superset/databases/commands/test_connection.py 84.78% <0.00%> (-4.35%) ⬇️
... and 547 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2adfb85...f350b57. Read the comment docs.

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! the wait loop could be method so you don't repeat yourself

tests/celery_tests.py Outdated Show resolved Hide resolved
@kstrz
Copy link
Contributor Author

kstrz commented Feb 3, 2021

Hey! Could you look at it? @willbarrett @dpgaspar

@willbarrett willbarrett merged commit 742d560 into apache:master Feb 3, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants