-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(alert/report): add/edit modal issue #12955
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12955 +/- ##
==========================================
+ Coverage 69.18% 69.43% +0.24%
==========================================
Files 1025 1036 +11
Lines 48814 48944 +130
Branches 5188 5294 +106
==========================================
+ Hits 33772 33982 +210
+ Misses 14908 14837 -71
+ Partials 134 125 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -104,6 +104,19 @@ const RETENTION_OPTIONS = [ | |||
const DEFAULT_RETENTION = 90; | |||
const DEFAULT_WORKING_TIMEOUT = 3600; | |||
const DEFAULT_CRON_VALUE = '* * * * *'; // every minute | |||
const DEFAULT_ALERT = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Nit: can we add a test? |
88cda3c
to
88fa550
Compare
88fa550
to
236d1f2
Compare
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
https://www.loom.com/share/47fde2a5390546dba8adbc9383ba778b
TEST PLAN
ADDITIONAL INFORMATION