Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert/report): add/edit modal issue #12955

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

lilykuang
Copy link
Member

SUMMARY

  • After deleting a report, add/edit modal doesn't reset the data

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
https://www.loom.com/share/47fde2a5390546dba8adbc9383ba778b

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Feb 4, 2021

Codecov Report

Merging #12955 (88cda3c) into master (2eff860) will increase coverage by 0.24%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12955      +/-   ##
==========================================
+ Coverage   69.18%   69.43%   +0.24%     
==========================================
  Files        1025     1036      +11     
  Lines       48814    48944     +130     
  Branches     5188     5294     +106     
==========================================
+ Hits        33772    33982     +210     
+ Misses      14908    14837      -71     
+ Partials      134      125       -9     
Flag Coverage Δ
cypress 53.37% <33.33%> (+2.54%) ⬆️
javascript 61.84% <33.33%> (+<0.01%) ⬆️
python 66.94% <ø> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/views/CRUD/alert/AlertList.tsx 75.96% <0.00%> (-0.60%) ⬇️
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 47.18% <50.00%> (+0.15%) ⬆️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/views/database/views.py 62.69% <0.00%> (-24.88%) ⬇️
superset/databases/commands/create.py 83.67% <0.00%> (-8.17%) ⬇️
superset/databases/commands/update.py 85.71% <0.00%> (-8.17%) ⬇️
superset/sql_validators/base.py 93.33% <0.00%> (-6.67%) ⬇️
superset/db_engine_specs/sqlite.py 90.62% <0.00%> (-6.25%) ⬇️
superset/db_engine_specs/base.py 79.85% <0.00%> (-6.15%) ⬇️
superset/db_engine_specs/presto.py 82.25% <0.00%> (-6.07%) ⬇️
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eff860...88cda3c. Read the comment docs.

@@ -104,6 +104,19 @@ const RETENTION_OPTIONS = [
const DEFAULT_RETENTION = 90;
const DEFAULT_WORKING_TIMEOUT = 3600;
const DEFAULT_CRON_VALUE = '* * * * *'; // every minute
const DEFAULT_ALERT = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@willbarrett
Copy link
Member

Nit: can we add a test?

@lilykuang lilykuang merged commit f10dbbe into apache:master Feb 16, 2021
@lilykuang lilykuang deleted the lily/alert-modal-fix branch February 16, 2021 19:18
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants