fix: vertical scroll in query history

[betodealmeida]

SUMMARY

Vertical scrolling in the query history in SQL Editor is currently broken. This PR fixes #12922.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Scrolling now works:

TEST PLAN

I tested other tabs (preview, results) and everything works as expected.

ADDITIONAL INFORMATION

• Has associated issue: [SQL Lab] Can't scroll in SQL Lab Query History #12922
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[codecov-io]

Codecov Report

Merging #13042 (641d3eb) into master (2ce7982) will increase coverage by 19.91%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #13042       +/-   ##
===========================================
+ Coverage   53.06%   72.97%   +19.91%     
===========================================
  Files         489      546       +57     
  Lines       17314    20175     +2861     
  Branches     4482     5212      +730     
===========================================
+ Hits         9187    14723     +5536     
+ Misses       8127     5327     -2800     
- Partials        0      125      +125     

Flag	Coverage Δ
cypress	53.38% <100.00%> (+0.32%)	⬆️
javascript	61.86% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...perset-frontend/src/views/CRUD/chart/ChartList.tsx	84.25% <ø> (+9.94%)	⬆️
...rontend/src/views/CRUD/dashboard/DashboardCard.tsx	83.78% <ø> (+7.78%)	⬆️
...rontend/src/components/ListView/CardSortSelect.tsx	95.83% <100.00%> (+16.88%)	⬆️
...rset-frontend/src/components/ListView/ListView.tsx	99.03% <100.00%> (+22.63%)	⬆️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx	80.18% <100.00%> (+13.87%)	⬆️
...tend/src/filters/components/Select/controlPanel.ts	18.18% <0.00%> (-81.82%)	⬇️
superset-frontend/src/views/index.tsx	25.00% <0.00%> (-75.00%)	⬇️
superset-frontend/src/SqlLab/index.tsx	25.00% <0.00%> (-75.00%)	⬇️
...ntend/src/filters/components/Range/controlPanel.ts	25.00% <0.00%> (-75.00%)	⬇️
superset-frontend/src/views/App.tsx	25.58% <0.00%> (-74.42%)	⬇️
... and 408 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a96102...641d3eb. Read the comment docs.

[rusackas]

This looks like it should be just fine, and limited in scope to SQL Lab, so I'll approve. That said, I'm always a little nervous about things like this since it affects EVERY AntD tab content area in SQL Lab. This will probably not be an issue, but it's one of those little things that might crop up in unexpected places. Perhaps @kgabryje would want to weigh in here as he's close to that component.

Also, if these ant styles are only used in one or two places, it might make sense to move them into the React components and employ Emotion via styled.div or the css prop. Then we'd have less LESS!

[betodealmeida]

Also, if these ant styles are only used in one or two places, it might make sense to move them into the React components and employ Emotion via styled.div or the css prop. Then we'd have less LESS!

+1 on that, I like the approach of using Superset components that abstract the underlying library.