Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sort by for dist bar chart #13049

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Conversation

maloun96
Copy link
Contributor

@maloun96 maloun96 commented Feb 10, 2021

Add control for sort by "asc" or "desc"

Associated with: apache-superset/superset-ui#947

AFTER

DEV.Vaccine.Ca.mp4

TEST PLAN

Go to any Bar Chart
Select Sort By

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@maloun96 maloun96 changed the title Add sort by for dist bar chart (feat) Add sort by for dist bar chart Feb 10, 2021
@maloun96 maloun96 changed the title (feat) Add sort by for dist bar chart feat: Add sort by for dist bar chart Feb 10, 2021
@codecov-io
Copy link

codecov-io commented Feb 10, 2021

Codecov Report

Merging #13049 (ab98051) into master (2ce7982) will increase coverage by 13.92%.
The diff coverage is 58.62%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #13049       +/-   ##
===========================================
+ Coverage   53.06%   66.98%   +13.92%     
===========================================
  Files         489      489               
  Lines       17314    28790    +11476     
  Branches     4482        0     -4482     
===========================================
+ Hits         9187    19285    +10098     
- Misses       8127     9505     +1378     
Flag Coverage Δ
cypress ?
python 66.98% <58.62%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 90.64% <ø> (ø)
...s/260bf0649a77_migrate_x_dateunit_in_time_range.py 0.00% <0.00%> (ø)
superset/viz.py 59.01% <55.55%> (ø)
superset/charts/commands/exceptions.py 92.85% <77.77%> (ø)
superset/utils/date_parser.py 96.87% <100.00%> (ø)
superset-frontend/src/components/FlashProvider.tsx
...frontend/src/explore/components/DataTablesPane.tsx
...ontend/src/components/CertifiedIconWithTooltip.tsx
...perset-frontend/src/utils/DebouncedMessageQueue.js
...et-frontend/src/SqlLab/components/QueryHistory.jsx
... and 968 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a96102...ab98051. Read the comment docs.

@junlincc junlincc added explore:sort Related to sorting in Explore design-sys-revisit labels Feb 11, 2021
@junlincc
Copy link
Member

thanks for the PR, @maloun96! is asc set by default if we don't check the sort descending box?

@villebro villebro merged commit e8d5035 into apache:master Feb 22, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:sort Related to sorting in Explore size/S 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants