feat(native-filters): enable filter indicator and make datasource optional #13148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
approved these changes
Feb 16, 2021
simcha90
changed the title
| const [state, setState] = useState([]); | ||
| const [error, setError] = useState<boolean>(false); | ||
| const [formData, setFormData] = useState<Partial<QueryFormData>>({}); | ||
| const inputRef = useRef<HTMLInputElement>(null); | ||
| const [target] = targets; | ||
| const { datasetId = 18, column } = target; | ||
| const { | ||
| datasetId = 18, |
There was a problem hiding this comment.
no idea, it was here
There was a problem hiding this comment.
but may be good remove it
Codecov Report
@@ Coverage Diff @@
## master #13148 +/- ##
==========================================
+ Coverage 53.06% 53.52% +0.46%
==========================================
Files 489 493 +4
Lines 17314 17398 +84
Branches 4482 4521 +39
==========================================
+ Hits 9187 9313 +126
+ Misses 8127 8085 -42
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
junlincc
added
the
dashboard:native-filters
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR decouple decouple filter params from native filters config modal. In this phase we decoupled datasource based on
datasourceCountproperty that exported from every viz-pluginMore changes:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-02-16.at.12.09.49.mov
TEST PLAN
ADDITIONAL INFORMATION