New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: optimize codecov config #13329
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13329 +/- ##
==========================================
- Coverage 77.08% 77.01% -0.07%
==========================================
Files 876 876
Lines 45439 45439
Branches 5440 5440
==========================================
- Hits 35026 34997 -29
- Misses 10290 10319 +29
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Jesse for the optimization! Apologies for the unintended consequences.
* test: optimize codecov config to let GitHub checks always pass * Run tests on workflow changes, too
SUMMARY
Optimize CodeCov config to
It seems the CodeCov App has recently been enabled in this repo (#9930), which is good, but it starts to block some PRs on status check due to false alarms of decreased test coverage.
This is because:
The
after_n_builds
config is designed to address this issue, but since we don't know which jobs will run for each PR, we can't really set a meaningful value for this config.I'm setting it to 4 because for Python tests there are 5 uploads (mysql, postgres, sqlite, hive, presto), and for frontend, there are 4 (unit tests + Cypress * 3).
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
ADDITIONAL INFORMATION