Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix codecov informational config #13375

Merged
merged 1 commit into from Mar 1, 2021
Merged

build: fix codecov informational config #13375

merged 1 commit into from Mar 1, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Feb 28, 2021

SUMMARY

The informational flag added by #13329 was incorrectly added, which means the status checks were not really turned off as expected.

This PR should fix it.

Long-term solution is to use Carryforward Flags as suggested here: #9930 (comment)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

  1. CI should pass
  2. After merge, CI should not be blocked in PRs that do not run all jobs.

Example: #13374

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

etr2460
etr2460 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this, it should unblock PR merging I think

@ktmud ktmud merged commit 8f09c62 into apache:master Mar 1, 2021
@ktmud ktmud deleted the codecov-config branch March 1, 2021 19:39
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
@ktmud
build: fix codecov informational config (apache#13375)
3c2cdcd
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

@willbarrett willbarrett Awaiting requested review from willbarrett

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ktmud @etr2460 @mistercrunch