Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding v0 import/export fields to dashboard metadata schema #13425

Conversation

michellethomas
Copy link
Contributor

SUMMARY

We see errors editing the metadata for dashboards that were imported using the v0 import/export feature. I'm adding those fields to the DashboardJSONMetadataSchema so we don't see those errors on validation. I'm adding these fields to the schema instead of removing them because the v0 import/export feature uses them.

I tested this change by editing a chart with these fields, let me know if there's anything else to test with this change.

TEST PLAN

I tested editing a chart that had these fields in the dashboard json_metadata.

ADDITIONAL INFORMATION

@betodealmeida @dpgaspar @serenajiang

@michellethomas michellethomas changed the title Adding v0 import/export fields to dashboard metadata schema fix: Adding v0 import/export fields to dashboard metadata schema Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #13425 (979de43) into master (70e12ed) will decrease coverage by 5.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13425      +/-   ##
==========================================
- Coverage   77.23%   71.57%   -5.66%     
==========================================
  Files         900      802      -98     
  Lines       45599    40615    -4984     
  Branches     5415     4147    -1268     
==========================================
- Hits        35219    29072    -6147     
- Misses      10253    11543    +1290     
+ Partials      127        0     -127     
Flag Coverage Δ
cypress 57.96% <100.00%> (+0.01%) ⬆️
hive ?
javascript ?
mysql 80.31% <100.00%> (+<0.01%) ⬆️
postgres 80.35% <100.00%> (+<0.01%) ⬆️
presto 80.00% <100.00%> (-0.01%) ⬇️
python 80.57% <100.00%> (-0.29%) ⬇️
sqlite 79.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/chart/chartReducer.ts 55.22% <100.00%> (ø)
.../src/explore/components/ControlPanelsContainer.tsx 96.84% <100.00%> (-0.36%) ⬇️
...t-frontend/src/explore/reducers/getInitialState.ts 100.00% <100.00%> (ø)
superset/dashboards/schemas.py 98.87% <100.00%> (+0.02%) ⬆️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/components/Pagination/Ellipsis.tsx 0.00% <0.00%> (-100.00%) ⬇️
...-frontend/src/components/OmniContainer/Omnibar.tsx 0.00% <0.00%> (-100.00%) ⬇️
...dashboard/components/resizable/ResizableHandle.jsx 0.00% <0.00%> (-100.00%) ⬇️
...tersConfigModal/Footer/CancelConfirmationAlert.tsx 0.00% <0.00%> (-100.00%) ⬇️
... and 476 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e12ed...2560104. Read the comment docs.

@junlincc junlincc requested a review from dpgaspar March 3, 2021 03:53
@etr2460 etr2460 merged commit 95809e5 into apache:master Mar 4, 2021
allanco91 pushed a commit to allanco91/superset that referenced this pull request May 21, 2021
…3425)

Co-authored-by: michelle_thomas <michelle.thomas@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown Field error when editing dashboards with remote_id and import_time
4 participants