chore: Improved translation into Russian language #14412

aleksandrgordienko · 2021-04-29T11:04:38Z

SUMMARY

Improved translation to Russian language.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

ADDITIONAL INFORMATION

Has associated issue: Need improved translation into Russian #14405
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2021-04-30T19:17:58Z

Codecov Report

Merging #14412 (be0ffc2) into master (e8e838e) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14412      +/-   ##
==========================================
- Coverage   77.31%   77.06%   -0.26%     
==========================================
  Files         958      958              
  Lines       48287    48268      -19     
  Branches     5658     5645      -13     
==========================================
- Hits        37335    37196     -139     
- Misses      10750    10871     +121     
+ Partials      202      201       -1

Flag	Coverage Δ
hive	`80.80% <ø> (ø)`
mysql	`81.06% <ø> (ø)`
postgres	`81.09% <ø> (ø)`
presto	`?`
python	`81.47% <ø> (-0.16%)`	⬇️
sqlite	`80.70% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...trols/DateFilterControl/components/CommonFrame.tsx	`41.66% <0.00%> (-50.00%)`	⬇️
...nents/nativeFilters/FilterBar/FilterSets/index.tsx	`47.00% <0.00%> (-30.00%)`	⬇️
...et-frontend/src/dashboard/actions/nativeFilters.ts	`53.84% <0.00%> (-26.16%)`	⬇️
...t-frontend/src/dashboard/reducers/nativeFilters.ts	`64.70% <0.00%> (-23.53%)`	⬇️
...nts/controls/DateFilterControl/DateFilterLabel.tsx	`72.03% <0.00%> (-11.02%)`	⬇️
...nativeFilters/FilterBar/FilterSets/EditSection.tsx	`80.39% <0.00%> (-9.81%)`	⬇️
...board/components/nativeFilters/FilterBar/index.tsx	`92.94% <0.00%> (-7.06%)`	⬇️
superset/db_engine_specs/presto.py	`84.42% <0.00%> (-5.90%)`	⬇️
...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx	`96.15% <0.00%> (-3.85%)`	⬇️
...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx	`91.66% <0.00%> (-2.78%)`	⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e838e...be0ffc2. Read the comment docs.

etr2460

Thanks for the contribution! I've asked around to see if anyone knows Russian and can review, but if not I'll plan to merge in a couple days

GGPay

Some charts are translated to Russian, some - not. Such as - Heatmap and Bubble chart and etc. Also - DELETE and OVERWRITE no need to be translated - otherwise user might have a confuse when typing "УДАЛИТЬ" and nothing happen on backend.

superset/translations/ru/LC_MESSAGES/messages.json

superset/translations/ru/LC_MESSAGES/messages.po

superset/translations/ru/LC_MESSAGES/messages.json

aleksandrgordienko · 2021-05-05T14:35:03Z

Some charts are translated to Russian, some - not. Such as - Heatmap and Bubble chart and etc. Also - DELETE and OVERWRITE no need to be translated - otherwise user might have a confuse when typing "УДАЛИТЬ" and nothing happen on backend.

Fixed

GGPay

Thank you for hard working!

rusackas · 2021-05-06T05:32:54Z

This is great, thank you!

etr2460 · 2021-05-06T15:11:48Z

Looks like the linter needs to be run on the translations file (see the failing CI). otherwise lgtm!

aleksandrgordienko · 2021-05-06T15:55:24Z

Looks like the linter needs to be run on the translations file (see the failing CI). otherwise lgtm!

Fixed with 'npx prettier --write'

etr2460 · 2021-05-06T23:13:15Z

Sorry, looks like this needs to be rebased too :'(

junlincc

we have an internal native speaker looked at the pr, looks good to us.
approving from the product standpoint. @rusackas @etr2460 🟢 i will let you press the green button.
please do rebase 🙏

"I've screened the PR, an it looks good, I mean it looks like it was a native speaker who did the translation, or translator tools became very smart)"

aleksandrgordienko · 2021-05-07T08:16:03Z

we have an internal native speaker looked at the pr, looks good to us.
approving from the product standpoint. @rusackas @etr2460 green_circle i will let you press the green button.
please do rebase pray

"I've screened the PR, an it looks good, I mean it looks like it was a native speaker who did the translation, or translator tools became very smart)"

Ha-ha, thank you! I'm definitely a native speaker :)

* fix: SQLLab role permissions * add missing perm * fix tests * fix security test * fix security test * fix tests

* Add aria-label and twotone * Enhance LazyIcon * Fix tests and solve ject warnings * Add new line * Revert package-lock to master * Fix failing test * Implement icon overrides * Fix failing storybook * Clean up * Improve var name

* add limiting factor to query model * varchar instead of enum

…la from impala in index.mdx (#14425)

* fix parsing error messages that are formatted as single strings * fix other instances of error typing

etr2460

thanks for wrestling with CI, this is good to go now!

srinify mentioned this pull request Apr 29, 2021

Need improved translation into Russian #14405

Closed

aleksandrgordienko changed the title ~~Improved translation into Russian language~~ chore: Improved translation into Russian language Apr 30, 2021

etr2460 reviewed May 4, 2021

View reviewed changes

GGPay reviewed May 5, 2021

View reviewed changes

junlincc added the i18n:general Related to translations label May 5, 2021

khaa-dv reviewed May 5, 2021

View reviewed changes

superset/translations/ru/LC_MESSAGES/messages.json Outdated Show resolved Hide resolved

GGPay approved these changes May 5, 2021

View reviewed changes

junlincc self-requested a review May 6, 2021 23:33

junlincc reviewed May 6, 2021

View reviewed changes

aleksandrgordienko requested a review from a team as a code owner May 7, 2021 09:57

villebro and others added 13 commits May 7, 2021 13:03

fix(native-filters): always show filters without dataset (#14409)

fcc23c6

fix: SQLLab role permissions (#14372)

18e9fb1

* fix: SQLLab role permissions * add missing perm * fix tests * fix security test * fix security test * fix tests

feat: Support env vars configuration for WebSocket server (#14398)

73082a9

feat: Dynamic imports for the Icons component (#14318)

d719114

* Add aria-label and twotone * Enhance LazyIcon * Fix tests and solve ject warnings * Add new line * Revert package-lock to master * Fix failing test * Implement icon overrides * Fix failing storybook * Clean up * Improve var name

chore: Moves Card to the components folder (#14139)

56ea6ca

feat: Add etag caching to dashboard APIs (#14357)

c5af548

feat: Adding limiting_factor column to Query model (#14234)

bd21aff

* add limiting factor to query model * varchar instead of enum

fix(native-filters): fix filter scope error (#14426)

8eb050f

Renamed impyla from implya in impala.mdx and Renamed PIP package impy…

b7807a2

…la from impala in index.mdx (#14425)

update README with new docs and recordings (#14432)

d43c1a7

chore: add stack trace to all calls of logger.error (#14382)

178d25b

fix: parse simple string error message values (#14360)

f1471dd

* fix parsing error messages that are formatted as single strings * fix other instances of error typing

fix: bootstrap data permissions (#14348)

86b7ad8

aleksandrgordienko added 22 commits May 7, 2021 13:15

Update messages.po

6381bf4

Update messages.json

6231c7b

Update messages.po

d6d5e86

Update messages.json

09c90f7

Update messages.po

1d7099c

Update messages.json

c57ac91

Update messages.po

5ef0778

Update messages.json

aca5c0d

Update messages.po

cc29994

Update messages.json

f1dc22d

Update messages.po

920af23

Update messages.po

691a9fa

Update messages.json

9006bb4

Update messages.po

5f46884

Update messages.json

e317149

Update messages.json

adc0fa6

Update messages.json

d1c45d7

Update messages.json

6a30da3

Formatted with prettier

1df29eb

Merge remote-tracking branch 'upstream/master' into russian-translation

1bbfb15

Fixed problems after rebase

bdb3b18

Fixed problems after rebase

be0ffc2

etr2460 approved these changes May 7, 2021

View reviewed changes

etr2460 merged commit c14665c into apache:master May 7, 2021

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021

chore: Improved translation into Russian language (apache#14412)

23f656d

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021

chore: Improved translation into Russian language (apache#14412)

d611331

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

chore: Improved translation into Russian language (apache#14412)

3c20a66

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Improved translation into Russian language #14412

chore: Improved translation into Russian language #14412

aleksandrgordienko commented Apr 29, 2021

codecov bot commented Apr 30, 2021 •

edited

Loading

etr2460 left a comment

GGPay left a comment •

edited

Loading

aleksandrgordienko commented May 5, 2021

GGPay left a comment

rusackas commented May 6, 2021

etr2460 commented May 6, 2021

aleksandrgordienko commented May 6, 2021

etr2460 commented May 6, 2021

junlincc left a comment •

edited

Loading

aleksandrgordienko commented May 7, 2021

etr2460 left a comment

chore: Improved translation into Russian language #14412

chore: Improved translation into Russian language #14412

Conversation

aleksandrgordienko commented Apr 29, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

codecov bot commented Apr 30, 2021 • edited Loading

Codecov Report

etr2460 left a comment

Choose a reason for hiding this comment

GGPay left a comment • edited Loading

Choose a reason for hiding this comment

aleksandrgordienko commented May 5, 2021

GGPay left a comment

Choose a reason for hiding this comment

rusackas commented May 6, 2021

etr2460 commented May 6, 2021

aleksandrgordienko commented May 6, 2021

etr2460 commented May 6, 2021

junlincc left a comment • edited Loading

Choose a reason for hiding this comment

aleksandrgordienko commented May 7, 2021

etr2460 left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 30, 2021 •

edited

Loading

GGPay left a comment •

edited

Loading

junlincc left a comment •

edited

Loading