Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes common storybook #14418

Merged
merged 1 commit into from May 5, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Moves the remaining common stories of the Storybook to its own folders.
  • While moving, also improves the stories to use dynamic controls and make it fully interactive

This work is part of SIP-61

@rusackas @junlincc

TEST PLAN

1 - Enter in storybook
2 - There should be no common stories

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #14418 (dbd79d5) into master (1c16261) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head dbd79d5 differs from pull request most recent head cb3c847. Consider uploading reports for the commit cb3c847 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14418      +/-   ##
==========================================
- Coverage   76.81%   76.79%   -0.02%     
==========================================
  Files         955      955              
  Lines       48249    48250       +1     
  Branches     6032     6032              
==========================================
- Hits        37063    37055       -8     
- Misses      10990    10999       +9     
  Partials      196      196              
Flag Coverage Δ
javascript 71.36% <ø> (ø)
postgres ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/InfoTooltip/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Modal/Modal.tsx 100.00% <ø> (ø)
superset/constants.py 100.00% <ø> (ø)
superset/security/manager.py 91.50% <100.00%> (+0.02%) ⬆️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/db_engine_specs/postgres.py 95.87% <0.00%> (-1.04%) ⬇️
superset/views/base_api.py 97.85% <0.00%> (-0.43%) ⬇️
superset/db_engine_specs/presto.py 90.31% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c16261...cb3c847. Read the comment docs.

@junlincc junlincc added the sip:61:folder-org Related to the organization of the folders as of SIP 61 label May 5, 2021
@junlincc junlincc requested a review from rusackas May 5, 2021 00:38
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 7182a1b into apache:master May 5, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels sip:61:folder-org Related to the organization of the folders as of SIP 61 size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants