Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes common storybook #14418

Merged
merged 1 commit into from May 5, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
134 changes: 0 additions & 134 deletions superset-frontend/src/common/components/common.stories.tsx

This file was deleted.

88 changes: 88 additions & 0 deletions superset-frontend/src/components/CronPicker/CronPicker.stories.tsx
@@ -0,0 +1,88 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React, { useState, useRef, useCallback } from 'react';
import { Input, Divider } from 'src/common/components';
import { CronPicker, CronError, CronProps } from '.';

export default {
title: 'CronPicker',
component: CronPicker,
};

export const InteractiveCronPicker = (props: CronProps) => {
// @ts-ignore
const inputRef = useRef<Input>(null);
const [value, setValue] = useState(props.value);
const customSetValue = useCallback(
(newValue: string) => {
setValue(newValue);
inputRef.current?.setValue(newValue);
},
[inputRef],
);
const [error, onError] = useState<CronError>();

return (
<div>
<Input
ref={inputRef}
onBlur={event => {
setValue(event.target.value);
}}
onChange={e => setValue(e.target.value || '')}
/>
<Divider />
<CronPicker
{...props}
value={value}
setValue={customSetValue}
onError={onError}
/>
{error && <p style={{ marginTop: 20 }}>Error: {error.description}</p>}
</div>
);
};

InteractiveCronPicker.args = {
clearButton: false,
disabled: false,
readOnly: false,
};

InteractiveCronPicker.argTypes = {
value: {
defaultValue: '30 5 * * *',
table: {
disable: true,
},
},
theme: {
table: {
disable: true,
},
},
};

InteractiveCronPicker.story = {
parameters: {
knobs: {
disable: true,
},
},
};
@@ -0,0 +1,79 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import InfoTooltip, { InfoTooltipProps } from 'src/components/InfoTooltip';

export default {
title: 'InfoTooltip',
component: InfoTooltip,
};

export const InteractiveInfoTooltip = (props: InfoTooltipProps) => {
const styles = {
padding: '100px 0 0 200px',
};

return (
<div style={styles}>
<InfoTooltip {...props} />
</div>
);
};

InteractiveInfoTooltip.args = {
tooltip: 'This is the text that will display!',
};

InteractiveInfoTooltip.argTypes = {
placement: {
defaultValue: 'top',
control: {
type: 'select',
options: [
'bottom',
'left',
'right',
'top',
'topLeft',
'topRight',
'bottomLeft',
'bottomRight',
'leftTop',
'leftBottom',
'rightTop',
'rightBottom',
],
},
},
trigger: {
defaultValue: 'hover',
control: {
type: 'select',
options: ['hover', 'click'],
},
},
};

InteractiveInfoTooltip.story = {
parameters: {
knobs: {
disable: true,
},
},
};
2 changes: 1 addition & 1 deletion superset-frontend/src/components/InfoTooltip/index.tsx
Expand Up @@ -22,7 +22,7 @@ import { styled } from '@superset-ui/core';
import { Tooltip } from 'src/components/Tooltip';
import Icon from 'src/components/Icon';

interface InfoTooltipProps {
export interface InfoTooltipProps {
className?: string;
tooltip: string;
placement?:
Expand Down
50 changes: 50 additions & 0 deletions superset-frontend/src/components/Modal/Modal.stories.tsx
@@ -0,0 +1,50 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import Modal, { ModalProps } from '.';

export default {
title: 'Modal',
component: Modal,
};

export const InteractiveModal = (props: ModalProps) => (
<Modal {...props}>Hi</Modal>
);

InteractiveModal.args = {
disablePrimaryButton: false,
primaryButtonName: 'Danger',
primaryButtonType: 'danger',
show: true,
title: "I'm a modal!",
};

InteractiveModal.argTypes = {
onHandledPrimaryAction: { action: 'onHandledPrimaryAction' },
onHide: { action: 'onHide' },
};

InteractiveModal.story = {
parameters: {
knobs: {
disable: true,
},
},
};
2 changes: 1 addition & 1 deletion superset-frontend/src/components/Modal/Modal.tsx
Expand Up @@ -23,7 +23,7 @@ import { Modal as BaseModal } from 'src/common/components';
import Button from 'src/components/Button';
import { css } from '@emotion/core';

interface ModalProps {
export interface ModalProps {
className?: string;
children: React.ReactNode;
disablePrimaryButton?: boolean;
Expand Down