chore: Replaces Icon with Icons component - iteration 1

[michael-s-molina]

SUMMARY

Replaces Icon with Icons component - iteration 1.

superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndSelectLabel.tsx
superset-frontend/src/explore/components/controls/DndColumnSelectControl/Option.tsx
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/index.jsx
superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.jsx
superset-frontend/src/explore/components/controls/OptionControls/index.tsx
superset-frontend/src/explore/components/ExploreActionButtons.tsx
superset-frontend/src/explore/components/EmbedCodeButton.jsx
superset-frontend/src/explore/components/ExploreViewContainer.jsx

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

@rusackas @pkdotson @geido

TEST PLAN

1 - Enter in all touched screens
2 - Check the icons

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[junlincc]

/testenv up

[github-actions]

@junlincc Ephemeral environment spinning up at http://52.12.88.193:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[codecov]

Codecov Report

Merging #14469 (37d1cc4) into master (4f5c537) will decrease coverage by 0.42%.
The diff coverage is 83.33%.

❗ Current head 37d1cc4 differs from pull request most recent head 60d4164. Consider uploading reports for the commit 60d4164 to get more accurate results

@@            Coverage Diff             @@
##           master   #14469      +/-   ##
==========================================
- Coverage   77.54%   77.11%   -0.43%     
==========================================
  Files         958      952       -6     
  Lines       48541    48169     -372     
  Branches     5702     6051     +349     
==========================================
- Hits        37640    37146     -494     
- Misses      10700    10823     +123     
+ Partials      201      200       -1     

Flag	Coverage Δ
javascript	71.91% <83.33%> (-0.61%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rontend/src/explore/components/EmbedCodeButton.jsx	80.76% <ø> (ø)
...nd/src/explore/components/ExploreViewContainer.jsx	2.32% <0.00%> (-0.02%)	⬇️
...ontrols/FilterControl/AdhocFilterControl/index.jsx	57.69% <ø> (ø)
...mponents/controls/MetricControl/MetricsControl.jsx	82.45% <ø> (ø)
...nd/src/explore/components/ExploreActionButtons.tsx	72.34% <100.00%> (ø)
...controls/DndColumnSelectControl/DndSelectLabel.tsx	85.00% <100.00%> (ø)
...ponents/controls/DndColumnSelectControl/Option.tsx	100.00% <100.00%> (ø)
...plore/components/controls/OptionControls/index.tsx	90.42% <100.00%> (-0.11%)	⬇️
...ontend/src/filters/components/Select/buildQuery.ts	25.00% <0.00%> (-75.00%)	⬇️
...trols/DateFilterControl/components/CommonFrame.tsx	41.66% <0.00%> (-50.00%)	⬇️
... and 137 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5c537...60d4164. Read the comment docs.

[geido]

LGTM!

[rusackas]

Just needs a quick rebase, but lgtm!