-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: db modal split #14470
feat: db modal split #14470
Conversation
* split db modal file * fix tests
/testenv up |
@hughhhh Container image not yet published for this PR. Please try again when build is complete. |
@hughhhh Ephemeral environment creation failed. Please check the Actions logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #14470 +/- ##
=======================================
Coverage 77.11% 77.12%
=======================================
Files 952 954 +2
Lines 48156 48175 +19
Branches 6054 6055 +1
=======================================
+ Hits 37137 37154 +17
- Misses 10818 10820 +2
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@hughhhh Ephemeral environment spinning up at http://54.185.177.209:8080. Credentials are |
I tested and found that an id is being passed on creation. I'll put up a fix. |
thanks for the PR! @eschutho |
5302f36
to
5cc4025
Compare
The failing test is passing for me locally, and doesn't look related to this code. @hughhhh can you try restarting it? thank you! |
/testenv up |
@hughhhh Ephemeral environment spinning up at http://34.211.107.19:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
* refactor: split db modal file (apache#14436) * split db modal file * fix tests * fix extra options * update database id methodology
* refactor: split db modal file (apache#14436) * split db modal file * fix tests * fix extra options * update database id methodology
* refactor: split db modal file (apache#14436) * split db modal file * fix tests * fix extra options * update database id methodology
SUMMARY
This change sets us up to switch between tabs and screens in the next iteration of the new db connection ui flow.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
The only change visually is the title and button on Create/Connect a database
![_DEV__Superset](https://user-images.githubusercontent.com/5186919/116744022-9c807500-a9ae-11eb-889a-7f6b07f76c45.png)
TEST PLAN
Tests should all pass
ADDITIONAL INFORMATION