-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split db modal file #14436
refactor: split db modal file #14436
Conversation
a5b4563
to
4557c1a
Compare
4557c1a
to
ce70bb8
Compare
Codecov Report
@@ Coverage Diff @@
## master #14436 +/- ##
==========================================
+ Coverage 76.79% 76.96% +0.17%
==========================================
Files 955 957 +2
Lines 48251 48114 -137
Branches 6030 6045 +15
==========================================
- Hits 37053 37032 -21
+ Misses 11003 10883 -120
- Partials 195 199 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@hughhhh Ephemeral environment spinning up at http://54.213.153.117:8080. Credentials are |
I checked the ephemeral environment, it all looks good to me! |
Ephemeral environment shutdown and build artifacts deleted. |
This reverts commit 2d991ec.
* split db modal file * fix tests
* split db modal file * fix tests
* refactor: split db modal file (#14436) * split db modal file * fix tests * fix extra options * update database id methodology
* split db modal file * fix tests
This reverts commit 2d991ec.
* refactor: split db modal file (apache#14436) * split db modal file * fix tests * fix extra options * update database id methodology
* split db modal file * fix tests
This reverts commit 2d991ec.
* refactor: split db modal file (apache#14436) * split db modal file * fix tests * fix extra options * update database id methodology
* split db modal file * fix tests
This reverts commit e3692dd.
* refactor: split db modal file (apache#14436) * split db modal file * fix tests * fix extra options * update database id methodology
SUMMARY
This change sets us up to switch between tabs and screens in the next iteration of the new db connection ui flow.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
The only change visually is the title and button on Create/Connect a database
TEST PLAN
Tests should all pass
ADDITIONAL INFORMATION