Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split db modal file #14436

Merged

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Apr 30, 2021

SUMMARY

This change sets us up to switch between tabs and screens in the next iteration of the new db connection ui flow.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

The only change visually is the title and button on Create/Connect a database
_DEV__Superset

TEST PLAN

Tests should all pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho force-pushed the elizabeth/split-database-modal-files branch 3 times, most recently from a5b4563 to 4557c1a Compare April 30, 2021 20:29
@eschutho eschutho force-pushed the elizabeth/split-database-modal-files branch from 4557c1a to ce70bb8 Compare April 30, 2021 22:24
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #14436 (a8d1ec8) into master (77d1715) will increase coverage by 0.17%.
The diff coverage is 70.86%.

❗ Current head a8d1ec8 differs from pull request most recent head 9f0c55b. Consider uploading reports for the commit 9f0c55b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14436      +/-   ##
==========================================
+ Coverage   76.79%   76.96%   +0.17%     
==========================================
  Files         955      957       +2     
  Lines       48251    48114     -137     
  Branches     6030     6045      +15     
==========================================
- Hits        37053    37032      -21     
+ Misses      11003    10883     -120     
- Partials      195      199       +4     
Flag Coverage Δ
javascript 71.64% <71.65%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/SqlLab/components/QueryTable.jsx 66.66% <ø> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 34.95% <ø> (ø)
superset-frontend/src/chart/Chart.jsx 50.00% <ø> (+5.93%) ⬆️
superset-frontend/src/chart/ChartContainer.jsx 100.00% <ø> (ø)
superset-frontend/src/dashboard/actions/hydrate.js 3.30% <0.00%> (-0.06%) ⬇️
...ters/FiltersConfigModal/FiltersConfigForm/state.ts 100.00% <ø> (ø)
...set-frontend/src/dashboard/containers/Dashboard.ts 0.00% <0.00%> (ø)
superset-frontend/src/dashboard/reducers/types.ts 0.00% <ø> (ø)
...nd/src/dashboard/util/activeAllDashboardFilters.ts 92.59% <0.00%> (-0.27%) ⬇️
superset-frontend/src/dataMask/types.ts 100.00% <ø> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77d1715...9f0c55b. Read the comment docs.

@hughhhh hughhhh self-requested a review May 3, 2021 15:46
@hughhhh
Copy link
Member

hughhhh commented May 3, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

@hughhhh Ephemeral environment spinning up at http://54.213.153.117:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@lyndsiWilliams
Copy link
Member

I checked the ephemeral environment, it all looks good to me!

@hughhhh hughhhh merged commit 2d991ec into apache:master May 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

Ephemeral environment shutdown and build artifacts deleted.

eschutho added a commit to preset-io/superset that referenced this pull request May 4, 2021
hughhhh pushed a commit that referenced this pull request May 4, 2021
eschutho added a commit to preset-io/superset that referenced this pull request May 4, 2021
* split db modal file

* fix tests
hughhhh pushed a commit that referenced this pull request May 4, 2021
* split db modal file

* fix tests
hughhhh pushed a commit that referenced this pull request May 4, 2021
hughhhh pushed a commit that referenced this pull request May 5, 2021
* refactor: split db modal file (#14436)

* split db modal file

* fix tests

* fix extra options

* update database id methodology
@eschutho eschutho deleted the elizabeth/split-database-modal-files branch May 10, 2021 15:57
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* split db modal file

* fix tests
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* refactor: split db modal file (apache#14436)

* split db modal file

* fix tests

* fix extra options

* update database id methodology
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* split db modal file

* fix tests
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* refactor: split db modal file (apache#14436)

* split db modal file

* fix tests

* fix extra options

* update database id methodology
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* split db modal file

* fix tests
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* refactor: split db modal file (apache#14436)

* split db modal file

* fix tests

* fix extra options

* update database id methodology
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XXL 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants