chore: Move styles from .less stylesheet to emotion in Explore #14485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
changed the title
Codecov Report
@@ Coverage Diff @@
## master #14485 +/- ##
==========================================
+ Coverage 77.11% 77.12% +0.01%
==========================================
Files 952 953 +1
Lines 48159 48189 +30
Branches 6050 6051 +1
==========================================
+ Hits 37137 37166 +29
- Misses 10821 10822 +1
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
simcha90
reviewed
May 5, 2021
| .edit-popover-resize { | ||
| transform: scaleX(-1); | ||
| -moz-transform: scaleX(-1); | ||
| -webkit-transform: scaleX(-1); |
There was a problem hiding this comment.
should we add all these prefixes?
There was a problem hiding this comment.
Nope, Emotion does it for us. Thanks!
simcha90
approved these changes
May 5, 2021
villebro
approved these changes
May 5, 2021
8 tasks
|
looks like we did some engineering QA before approving and merging this PR, i'm curious to know how the product could be affected in general by migration/refractor PR like this one? how can we better catch regression going forward? |
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…e#14485) * Move some styles from .less stylesheet to emotion in Explore * Replace Global styles with local styled components * Address comments
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…e#14485) * Move some styles from .less stylesheet to emotion in Explore * Replace Global styles with local styled components * Address comments
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…e#14485) * Move some styles from .less stylesheet to emotion in Explore * Replace Global styles with local styled components * Address comments
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR moves some styles from
src/explore/main.lessto Emotion. Also, removes.lessstylesheet in native filters - all the styles that we need are in the components.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Manually verify that everything looks as before on explore view and in native filters modal (with 1-2px accuracy caused by using
theme.gridUnit- for example, 30px margins becametheme.gridUnit * 7, which equals 28px).ADDITIONAL INFORMATION
CC: @simcha90 @villebro