fix: bringing metric type icon styles into SelectControl

[rusackas]

SUMMARY

PR #14485 cleaned up a bunch of LESS styles and moved them into Emotion. One style was also needed by the SelectControl component, and there was fallout from moving it away. This PR fixes it forward, putting the Emotion based styles where they're needed.

I believe this is further indication that we need to standardize our Select components (there are several), to minimize these surprise regressions.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

Pick any viz with a group by control - e.g. the Table viz. Check that the options in the menu don't look broken.

Test all over the place for related fallout.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #14531 (f7abce4) into master (6871ad1) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #14531      +/-   ##
==========================================
+ Coverage   77.09%   77.33%   +0.23%     
==========================================
  Files         959      959              
  Lines       48309    48310       +1     
  Branches     5661     5661              
==========================================
+ Hits        37243    37359     +116     
+ Misses      10866    10751     -115     
  Partials      200      200              

Flag	Coverage Δ
hive	80.81% <ø> (?)
javascript	72.40% <100.00%> (+<0.01%)	⬆️
mysql	81.07% <ø> (ø)
postgres	81.10% <ø> (ø)
presto	80.79% <ø> (?)
python	81.63% <ø> (+0.44%)	⬆️
sqlite	80.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../src/explore/components/controls/SelectControl.jsx	89.38% <100.00%> (+0.09%)	⬆️
superset/utils/core.py	89.00% <0.00%> (+0.12%)	⬆️
superset/models/core.py	89.13% <0.00%> (+0.27%)	⬆️
superset/db_engine_specs/base.py	88.09% <0.00%> (+0.43%)	⬆️
superset/connectors/sqla/models.py	90.07% <0.00%> (+1.69%)	⬆️
superset/views/database/mixins.py	82.75% <0.00%> (+1.72%)	⬆️
superset/db_engine_specs/presto.py	89.89% <0.00%> (+6.52%)	⬆️
superset/db_engine_specs/hive.py	87.39% <0.00%> (+17.07%)	⬆️
superset/db_engines/hive.py	82.14% <0.00%> (+82.14%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6871ad1...f7abce4. Read the comment docs.

[junlincc]

tested locally, LGTM! thanks for the fix! 🟢 added rush! and blocking!
cc @guhan @henryyeh

After:

Screen.Recording.2021-05-07.at.10.55.57.PM.mov

Before:

Screen.Recording.2021-05-07.at.11.27.31.AM.mov

[zhaoyongjie]

LGTM!

[junlincc]

i agree that we need to standardize our components once and for all, to prevent future regressions. and I think now is probably a good time to finish the project. though we don't have much left, it's necessary to come up with a good testing plan for high-risk PRs.