Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Attempt to reduce asyncEvent test flakiness #14497

Merged
merged 1 commit into from
May 6, 2021

Conversation

robdiciuccio
Copy link
Member

SUMMARY

Address the test flakiness mentioned in this comment by explicitly clearing the async event polling timeout.

TEST PLAN

FE asyncEvent tests pass without flakiness.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #14497 (aef3009) into master (7182a1b) will decrease coverage by 0.08%.
The diff coverage is 60.00%.

❗ Current head aef3009 differs from pull request most recent head a572e93. Consider uploading reports for the commit a572e93 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14497      +/-   ##
==========================================
- Coverage   77.12%   77.03%   -0.09%     
==========================================
  Files         953      953              
  Lines       48189    48191       +2     
  Branches     6051     6052       +1     
==========================================
- Hits        37164    37126      -38     
- Misses      10824    10864      +40     
  Partials      201      201              
Flag Coverage Δ
javascript 71.93% <60.00%> (-0.01%) ⬇️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/ExploreViewContainer.jsx 2.33% <ø> (ø)
superset-frontend/src/middleware/asyncEvent.ts 77.61% <60.00%> (-0.42%) ⬇️
superset/db_engine_specs/presto.py 84.42% <0.00%> (-5.48%) ⬇️
superset/connectors/sqla/models.py 88.61% <0.00%> (-1.46%) ⬇️
superset/models/core.py 88.85% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7182a1b...a572e93. Read the comment docs.

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@robdiciuccio robdiciuccio merged commit fa0915d into apache:master May 6, 2021
@robdiciuccio robdiciuccio deleted the rd/async-event-flake branch May 6, 2021 02:34
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants