fix: don't show busted label for unknown data types #14585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14585 +/- ##
==========================================
- Coverage 77.40% 77.40% -0.01%
==========================================
Files 958 958
Lines 48329 48329
Branches 5679 5679
==========================================
- Hits 37410 37408 -2
- Misses 10719 10721 +2
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@junlincc Ephemeral environment spinning up at http://54.68.112.58:8080. Credentials are |
|
Oops,,,, i meant to use my QA account to approve. sorry |
junlincc
added
need:merge
|
Ephemeral environment shutdown and build artifacts deleted. |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
May 18, 2021
(cherry picked from commit ad699e8)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In the dataset editor modal, data columns with unknown types showed odd looking little empty Label components. This simply doesn't render those. We can add in some other "unknown" icon or other treatment, but it seemed like "less is more" in this case.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
Pick a dataset in the CRUD view, click the pencil/edit action, and click the "Calculated Columns" tab to (most likely) see a specimen.
ADDITIONAL INFORMATION