-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixes top level tabs and automatic scroll #14624
Conversation
7cfc2be
to
d4da270
Compare
Codecov Report
@@ Coverage Diff @@
## master #14624 +/- ##
==========================================
- Coverage 77.38% 77.38% -0.01%
==========================================
Files 959 959
Lines 48465 48474 +9
Branches 5678 5683 +5
==========================================
+ Hits 37506 37510 +4
- Misses 10759 10763 +4
- Partials 200 201 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@junlincc Ephemeral environment spinning up at http://54.186.235.114:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Might be related to this PR
the top level tab cant be edited name after added
Unrelated to this PR
when user drag and drop a new tab component to a dashboard with multiple existing tabs all the existing tabs are replaced. i will file a separate issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit 9cb4a46)
SUMMARY
Fixes top-level tabs and automatic page scrolling.
@rusackas @junlincc
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
screen-recording-2021-05-13-at-15808-pm_OMxmjv4u.mov
screen-recording-2021-05-13-at-15125-pm_ujYbgYUg.mov
TEST PLAN
1 - Edit a dashboard
2 - Check that you can add a top-level tab
1 - Edit a dashboard with vertical scrolling
2 - Go to the bottom of the page
3 - Drag and hold a tab to the dashboard title
4 - The automatic scroll is activated
5 - Drop the tab on the main menu of Superset
6 - Scroll down
7 - The automatic scroll should have been disabled
ADDITIONAL INFORMATION