fix: Fixes top level tabs and automatic scroll

[michael-s-molina]

SUMMARY

Fixes top-level tabs and automatic page scrolling.

@rusackas @junlincc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

screen-recording-2021-05-13-at-15808-pm_OMxmjv4u.mov

screen-recording-2021-05-13-at-15125-pm_ujYbgYUg.mov

TEST PLAN

1 - Edit a dashboard
2 - Check that you can add a top-level tab

1 - Edit a dashboard with vertical scrolling
2 - Go to the bottom of the page
3 - Drag and hold a tab to the dashboard title
4 - The automatic scroll is activated
5 - Drop the tab on the main menu of Superset
6 - Scroll down
7 - The automatic scroll should have been disabled

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #14624 (d4da270) into master (3f6bd1e) will decrease coverage by 0.00%.
The diff coverage is 40.90%.

@@            Coverage Diff             @@
##           master   #14624      +/-   ##
==========================================
- Coverage   77.38%   77.38%   -0.01%     
==========================================
  Files         959      959              
  Lines       48465    48474       +9     
  Branches     5678     5683       +5     
==========================================
+ Hits        37506    37510       +4     
- Misses      10759    10763       +4     
- Partials      200      201       +1     

Flag	Coverage Δ
javascript	72.49% <40.90%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...d/components/DashboardBuilder/DashboardBuilder.tsx	86.95% <0.00%> (ø)
...ontend/src/dashboard/components/dnd/handleHover.js	9.09% <0.00%> (-2.03%)	⬇️
...set-frontend/src/dashboard/util/getDropPosition.js	82.53% <ø> (+0.72%)	⬆️
...src/dashboard/components/dnd/handleScroll/index.ts	65.21% <52.94%> (-8.12%)	⬇️
...-frontend/src/visualizations/presets/MainPreset.js	0.00% <0.00%> (ø)
...plore/components/controls/OptionControls/index.tsx	90.52% <0.00%> (ø)
...controls/FilterControl/AdhocFilterOption/index.jsx	100.00% <0.00%> (ø)
...onents/controls/FilterControl/AdhocFilter/index.js	97.01% <0.00%> (+0.09%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6bd1e...d4da270. Read the comment docs.

[junlincc]

/testenv up

[github-actions]

@junlincc Ephemeral environment spinning up at http://54.186.235.114:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[junlin-qa]

Thanks for the fix!

Might be related to this PR
the top level tab cant be edited name after added

Unrelated to this PR
when user drag and drop a new tab component to a dashboard with multiple existing tabs all the existing tabs are replaced. i will file a separate issue

[pkdotson]

LGTM!

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.