New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pin itsdangerous #14627
fix: Pin itsdangerous #14627
Conversation
81f770a
to
2c8bc91
Compare
Codecov Report
@@ Coverage Diff @@
## master #14627 +/- ##
=======================================
Coverage 77.38% 77.38%
=======================================
Files 959 959
Lines 48467 48467
Branches 5678 5678
=======================================
Hits 37508 37508
Misses 10759 10759
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, I think it's good to freeze this before it breaks anything.
2c8bc91
to
da70b3f
Compare
da70b3f
to
1504e51
Compare
Co-authored-by: John Bodley <john.bodley@airbnb.com> (cherry picked from commit 2bd0b62)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
SUMMARY
Version 2.0.0 of the itsdangerous package was recently released (May 12, 2021) which replaces the
simplejson
withjson
which cannot decodedecimal.Decimal
objects, i.e.,Eventually when we update Flask we will need to deal with this as it also removes
simplejson
(pallets/flask#3555) and doesn't rely on onitsdangerous
for defining which JSON package to use per pallets/flask#3562.I tried using the logic they suggested (to help future proof ourselves), i.e., in
superset/app.py
however I ran into a somewhat similar problem,
which is somewhat perplexing, i.e., I'm not sure why this is problematic and I couldn't find any JSON encoders in Superset, Flask, or Flask-SQLAlchemy which handled serializing SQLAlchemy
Table
objects. For now to remedy any issues resulting frompip installing
Apache Superset I thought there was merit in simply restricting the version ofitsdangerous
.Note the generated requirements were updated via,
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION