-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump pip-compile-multi #14633
chore: Bump pip-compile-multi #14633
Conversation
6ce8a91
to
3db127a
Compare
Codecov Report
@@ Coverage Diff @@
## master #14633 +/- ##
==========================================
+ Coverage 77.39% 77.47% +0.08%
==========================================
Files 958 958
Lines 48486 48486
Branches 5679 5679
==========================================
+ Hits 37524 37563 +39
+ Misses 10762 10723 -39
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'd really like to look into the dependabot option to replace pip-compile-multi
. If help is needed, I can try to find time to work on that.
BTW I'm a fan of @villebro if you or @nytai have time to explore this that would be great. I think one learning of auto-updating dependencies on a regular basis for a number of internal projects is it really only works if one has good test coverage, linting etc. which boosts one's confidence of the legitimacy of the PR, i.e., increases the likelihood of merging with little to no manual testing. The general lack of |
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
SUMMARY
Rumor has it that the
pip-compile-multi
ecosystem was likely borked, probably due to changes which i) used an improper version ofpip-compile-multi/pip-tools
, or ii) updates tosetup.py
etc. which didn't update the pinned requirements.This PR updates
pip-compile-multi
and updates therequirements/*.txt
files without upgrading any of the packages, via:Note we likely should look into something like http://dependabot.com/ or similar for ensuring dependencies remain fresh. See the Slack thread in the #committers channel here for more detail.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION