Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes group by control icon colors #14674

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes group by control icon colors.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-05-17 at 3 50 16 PM

Screen Shot 2021-05-17 at 3 47 11 PM

@rusackas @junlincc @kgabryje

TEST PLAN

1 - Go to explore
2 - Add a measure, filter and group by
3 - The icons should all look the same

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc added rush! Requires immediate attention bash! and removed rush! Requires immediate attention labels May 17, 2021
@junlincc
Copy link
Member

/testenv up

@junlincc junlincc added the explore:control Related to the controls panel of Explore label May 17, 2021
@github-actions
Copy link
Contributor

@junlincc Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment creation failed. Please check the Actions logs for details.

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #14674 (3f9a550) into master (4f5c537) will increase coverage by 0.00%.
The diff coverage is 94.73%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14674   +/-   ##
=======================================
  Coverage   77.54%   77.54%           
=======================================
  Files         958      958           
  Lines       48541    48534    -7     
  Branches     5702     5702           
=======================================
- Hits        37640    37636    -4     
+ Misses      10700    10698    -2     
+ Partials      201      200    -1     
Flag Coverage Δ
javascript 72.52% <94.73%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/explore/components/EmbedCodeButton.jsx 80.76% <ø> (ø)
...nd/src/explore/components/ExploreViewContainer.jsx 2.32% <0.00%> (-0.02%) ⬇️
...ponents/controls/DndColumnSelectControl/Option.tsx 100.00% <ø> (ø)
...ontrols/FilterControl/AdhocFilterControl/index.jsx 57.69% <ø> (ø)
...mponents/controls/MetricControl/MetricsControl.jsx 82.45% <ø> (ø)
...et-frontend/src/components/Menu/LanguagePicker.tsx 100.00% <100.00%> (+15.00%) ⬆️
...uperset-frontend/src/components/Menu/MenuRight.tsx 93.18% <100.00%> (ø)
...nd/src/explore/components/ExploreActionButtons.tsx 72.34% <100.00%> (ø)
...controls/DndColumnSelectControl/DndSelectLabel.tsx 85.00% <100.00%> (ø)
...plore/components/controls/OptionControls/index.tsx 90.42% <100.00%> (-0.11%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9deb7aa...3f9a550. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for the fix!

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.220.93.217:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit fd8b2cb into apache:master May 17, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@junlincc junlincc added rush! Requires immediate attention and removed rush! Requires immediate attention labels May 18, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:control Related to the controls panel of Explore size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants