-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): Icons width #14717
fix(explore): Icons width #14717
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14717 +/- ##
========================================
Coverage 77.53% 77.53%
========================================
Files 959 959
Lines 48648 48701 +53
Branches 5734 6115 +381
========================================
+ Hits 37718 37761 +43
- Misses 10729 10734 +5
- Partials 201 206 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
We had a conversation with @michael-s-molina to discuss the reason for the original change. By reverting the changes as I did in this PR, the related issue gets fixed but the padding of the icons in the GROUP BY control will be slightly affected. In order to avoid the back and forth, I'll resolve that problem as well in this PR and I'll update the status. |
This should be good to go now. CC @michael-s-molina @rusackas |
@geido Thanks for the fix. I have only a small suggestion to increase the |
Done! |
@michael-s-molina thanks for reviewing! can you review/test this PR locally with drag and drop enabled and on screen resize? Thanks! 🙏 |
screen-recording-2021-05-21-at-15810-pm_i4FrkZZi.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
* master: (163 commits) fix(native-filters): Manage default value of filters by superset (apache#14785) fix: Additional ResultSet tests (apache#14741) chore: added BasicParametersMixin to Redshift (apache#14752) fix: make dataset list sort case insensitive (apache#14528) fix: use encodeURIComponent when getting table metadata (apache#14790) fix: ensure engine is outside parameters (apache#14787) database modal should close on connect with tab layout (apache#14771) feat(native-filters): add search all filter options (apache#14710) fix: extra query in Dashboard when native filter enabled (apache#14770) chore: Improves the native filters UI/UX - iteration 2 (apache#14753) fix(native filters): Fix explore state (apache#14779) fix(explore): DndColumnSelect not handling controls with "multi: false" (apache#14737) feat: Create BigQuery Parameters for DatabaseModal (apache#14721) feat: enable user impersonation in GSheets (apache#14767) fix: add DB should not say it's Postgres (apache#14766) Revert "fix(dashboard): multiple query trigger when native filter enabled (apache#14734)" (apache#14762) feat: save database with new dynamic form (apache#14583) fix: save non-parameter DBs (apache#14759) chore: Removes ColorSchemeControl.less (apache#14199) fix(explore): Icons width (apache#14717) ...
Im still seeing this issue on master. in table chart. @geido |
appears that there are 2 separate icon issues, one in Explore select, one in Table formatter(which I reported). the second one was not fixed. please push a quick fix ASAP @geido Thanks To reproduce, go to any table charts, add columns, go to customize tab CUSTOMIZE COLUMN. see cosmetic |
* Revert width and margin * Adjust width * Increase margin
* Revert width and margin * Adjust width * Increase margin
* Revert width and margin * Adjust width * Increase margin
SUMMARY
It reverts a change of width and margin introduced in #14674 and adjusts the width of the icons in the options labels.
Fixes #14697
BEFORE
AFTER
TEST PLAN
ADDITIONAL INFORMATION