Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import dataset with extra; Vertica URI #14698

Merged
merged 2 commits into from
May 19, 2021

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented May 18, 2021

SUMMARY

Two small fixes for the import functionality:

  1. The schema for importing the extra field in datasets was incorrect, preventing datasets to be imported.
  2. The SQLAlchemy URI was being parsed with urllib.parse.urlparse to extract the password, but that failed on a Vertica URI (vertica+vertica_python://hackathon:XXXXXXXXXX@host:5433/dbname?ssl=1).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

Added unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #14698 (77663d5) into master (32f5f36) will decrease coverage by 0.20%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14698      +/-   ##
==========================================
- Coverage   77.51%   77.31%   -0.21%     
==========================================
  Files         958      958              
  Lines       48560    48572      +12     
  Branches     5703     5703              
==========================================
- Hits        37642    37554      -88     
- Misses      10718    10818     +100     
  Partials      200      200              
Flag Coverage Δ
hive ?
mysql 81.37% <100.00%> (-0.01%) ⬇️
postgres 81.40% <100.00%> (?)
presto ?
python 81.48% <100.00%> (-0.38%) ⬇️
sqlite 81.02% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/SqlLab/components/SouthPane/state.ts 100.00% <ø> (ø)
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 54.62% <ø> (ø)
...src/components/FilterableTable/FilterableTable.tsx 82.26% <ø> (ø)
...erset-frontend/src/SqlLab/components/ResultSet.tsx 70.00% <66.66%> (ø)
...rset-frontend/src/SqlLab/components/QueryTable.jsx 66.66% <100.00%> (ø)
...tend/src/SqlLab/components/SouthPane/SouthPane.tsx 79.54% <100.00%> (ø)
superset/databases/schemas.py 99.54% <100.00%> (-0.01%) ⬇️
superset/datasets/commands/export.py 78.72% <100.00%> (ø)
superset/datasets/commands/importers/v1/utils.py 57.14% <100.00%> (ø)
superset/datasets/schemas.py 96.46% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a011c...77663d5. Read the comment docs.

@betodealmeida betodealmeida merged commit 5e95d46 into apache:master May 19, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* fix: import dataset with extra; Vertica URI

* Fix lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix: import dataset with extra; Vertica URI

* Fix lint
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix: import dataset with extra; Vertica URI

* Fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants