Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): Use import_datasources.yaml, if it exists #14704

Merged
merged 4 commits into from
Jun 21, 2021
Merged

fix(helm): Use import_datasources.yaml, if it exists #14704

merged 4 commits into from
Jun 21, 2021

Conversation

danielewood
Copy link
Contributor

SUMMARY

Fixes oversight in #10771 to import the yaml if it is present.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@danielewood danielewood mentioned this pull request May 19, 2021
Merged
8 tasks
@nytai nytai merged commit 1948678 into apache:master Jun 21, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@danielewood
fix(helm): Use import_datasources.yaml, if it exists (apache#14704)
bd9e715
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@danielewood
fix(helm): Use import_datasources.yaml, if it exists (apache#14704)
327082e
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@danielewood
fix(helm): Use import_datasources.yaml, if it exists (apache#14704)
d642b9e
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytai nytai nytai approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielewood @nytai @mistercrunch