Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): Make local admin optional #14703

Merged
merged 2 commits into from
Jun 16, 2021
Merged

feat(helm): Make local admin optional #14703

merged 2 commits into from
Jun 16, 2021

Conversation

danielewood
Copy link
Contributor

@danielewood danielewood commented May 19, 2021 •
edited
Loading

SUMMARY

Makes local admin an optional parameter in the helm chart. Useful for deploying with no local admin account or existing install.

Defaults to keeping enabled.

Depends on #14704 to make the chart version correct and the linter happy.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

amitmiran137
amitmiran137 approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
thanks for your contribution

@amitmiran137 amitmiran137 merged commit 9282c58 into apache:master Jun 16, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@danielewood
feat(helm): Make local admin optional (apache#14703)
0359dd2 
* Make local admin optional

* fix for linting
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@danielewood
feat(helm): Make local admin optional (apache#14703)
d89049a 
* Make local admin optional

* fix for linting
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@danielewood
feat(helm): Make local admin optional (apache#14703)
19b8620 
* Make local admin optional

* fix for linting
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitmiran137 amitmiran137 amitmiran137 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielewood @amitmiran137 @mistercrunch