-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improves the native filters UI/UX - iteration 1 #14714
chore: Improves the native filters UI/UX - iteration 1 #14714
Conversation
Great work @michael-s-molina; Going to review shortly! |
Codecov Report
@@ Coverage Diff @@
## master #14714 +/- ##
==========================================
- Coverage 77.53% 77.45% -0.08%
==========================================
Files 959 959
Lines 48648 48663 +15
Branches 5734 5734
==========================================
- Hits 37718 37691 -27
- Misses 10729 10771 +42
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks for the first step. @michael-s-molina how many iteration we need to get to the progressive reveal action? |
@junlincc I'm planning to work on it in iteration 3. Iteration 2 is to create the collapse panels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the touch-ups, already looking much better 👍 Code LGTM + tested to work well without any noticeable side-effects.
LGTM!! Let's go team |
(cherry picked from commit d924223)
SUMMARY
Improves the native filters UI/UX - iteration 1.
height
for the modalPS: A future PR will handle the case of automatically selecting a tab/collapse when an error occurs.
@villebro @rusackas @junlincc
This work is part of the Native dashboard filter project
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
screen-recording-2021-05-19-at-114310-am_ooerR66l.mov
screen-recording-2021-05-19-at-113916-am_rc8CRINA.mov
TEST PLAN
1 - Execute all tests
2 - All tests should pass
ADDITIONAL INFORMATION