-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(native-filters): Unable to clear default value in native select filter #14739
fix(native-filters): Unable to clear default value in native select filter #14739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## master #14739 +/- ##
==========================================
- Coverage 77.54% 77.53% -0.01%
==========================================
Files 959 959
Lines 48696 48715 +19
Branches 5743 6115 +372
==========================================
+ Hits 37762 37772 +10
- Misses 10733 10737 +4
- Partials 201 206 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving a batch of native filter PRs, will test all as a whole ASAP.
SUMMARY
Fixes: #14713
@villebro @rusackas @junlincc
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Check the original issue for before/after videos.
TEST PLAN
Check the original issue for the test plan.
ADDITIONAL INFORMATION