Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): Unable to clear default value in native select filter #14739

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes: #14713

@villebro @rusackas @junlincc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Check the original issue for before/after videos.

TEST PLAN

Check the original issue for the test plan.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro changed the title fix: Unable to clear default value in native select filter fix(native-filters): Unable to clear default value in native select filter May 20, 2021
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label May 20, 2021
@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #14739 (5f00a9f) into master (a9d888a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14739      +/-   ##
==========================================
- Coverage   77.54%   77.53%   -0.01%     
==========================================
  Files         959      959              
  Lines       48696    48715      +19     
  Branches     5743     6115     +372     
==========================================
+ Hits        37762    37772      +10     
- Misses      10733    10737       +4     
- Partials      201      206       +5     
Flag Coverage Δ
javascript 72.51% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ters/FiltersConfigModal/FiltersConfigForm/utils.ts 93.33% <100.00%> (+0.47%) ⬆️
...ontrols/AnnotationLayerControl/AnnotationLayer.jsx 83.40% <0.00%> (-0.88%) ⬇️
...mponents/controls/AnnotationLayerControl/index.jsx 7.79% <0.00%> (-0.55%) ⬇️
...end/src/SqlLab/components/RunQueryActionButton.tsx 64.28% <0.00%> (ø)
...d/src/filters/components/GroupBy/transformProps.ts 33.33% <0.00%> (ø)
...src/filters/components/TimeGrain/transformProps.ts 33.33% <0.00%> (ø)
...rc/filters/components/TimeColumn/transformProps.ts 33.33% <0.00%> (ø)
...ts/nativeFilters/FilterBar/FilterControls/state.ts 80.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d888a...5f00a9f. Read the comment docs.

Copy link

@junlin-qa junlin-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving a batch of native filter PRs, will test all as a whole ASAP.

@pkdotson pkdotson merged commit 173c486 into apache:master May 21, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to clear default value in native select filter
6 participants