-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pivot): default missing series to NULL_STRING #14748
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14748 +/- ##
==========================================
- Coverage 77.53% 77.45% -0.08%
==========================================
Files 960 960
Lines 48744 48745 +1
Branches 6122 6122
==========================================
- Hits 37793 37756 -37
- Misses 10745 10783 +38
Partials 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
BEFORE
On the chart data endpoint, missing series names are currently removed from the dataset:
AFTER
Now missing series names are replaced with
<NULL>
and the series show up on the chart.TESTING INSTRUCTIONS
CI + new tests
ADDITIONAL INFORMATION