Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pivot): default missing series to NULL_STRING #14748

Merged
merged 1 commit into from
May 21, 2021

Conversation

villebro
Copy link
Member

SUMMARY

BEFORE

On the chart data endpoint, missing series names are currently removed from the dataset:
image

AFTER

Now missing series names are replaced with <NULL> and the series show up on the chart.
image

TESTING INSTRUCTIONS

CI + new tests

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #14748 (0871ade) into master (29828f8) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14748      +/-   ##
==========================================
- Coverage   77.53%   77.45%   -0.08%     
==========================================
  Files         960      960              
  Lines       48744    48745       +1     
  Branches     6122     6122              
==========================================
- Hits        37793    37756      -37     
- Misses      10745    10783      +38     
  Partials      206      206              
Flag Coverage Δ
hive 81.10% <100.00%> (+<0.01%) ⬆️
mysql 81.38% <100.00%> (+<0.01%) ⬆️
postgres 81.40% <100.00%> (+<0.01%) ⬆️
presto ?
python 81.78% <100.00%> (-0.15%) ⬇️
sqlite 81.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/pandas_postprocessing.py 84.46% <100.00%> (+0.46%) ⬆️
superset/db_engine_specs/presto.py 84.42% <0.00%> (-5.48%) ⬇️
superset/connectors/sqla/models.py 88.70% <0.00%> (-1.45%) ⬇️
superset/models/core.py 89.70% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29828f8...0871ade. Read the comment docs.

@junlincc junlincc added demo release:note !deprecated-label:viz:explore:others Deprecated label - Use explore instead labels May 21, 2021
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 7c17b1a into apache:master May 21, 2021
@junlincc junlincc removed the demo label May 28, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels !deprecated-label:viz:explore:others Deprecated label - Use explore instead preset-io release:note size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants